From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Dan Carpenter'" <dan.carpenter@oracle.com>,
James Simmons <jsimmons@infradead.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
"HPDD-discuss@ml01.01.org" <HPDD-discuss@ml01.01.org>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c
Date: Wed, 27 May 2015 15:01:37 +0000 [thread overview]
Message-ID: <dd9883629dd64028b5c4e6a33d17a431@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <20150525093737.GS4150@mwanda>
>>On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote:
>> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
>> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
>> toobig = 1;
>> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
>> - CWARN("Too many interfaces: only enumerating first %d\n",
>> - nalloc);
>> + CWARN("Too many interfaces: only enumerating "
>> + "first %d\n", nalloc);
>> }
>
>Don't split string literals, it makes them hard to grep for.
Will fix. The CWARN will go over 80 characters but from the recent emails that is more acceptable.
If this is the only problem then this patch set it ready. I have more patch series that are dependent
on this first one. Should I push the other patch series with a note that it is dependent on the tcpip
cleanup or wait until it is merged? Also how does one find out when the patch has been merged?
next prev parent reply other threads:[~2015-05-27 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <uja.ornl@gmail.com>
2015-05-21 22:46 ` [PATCH 0/3] First set of Intel branch merger for libcfs/lnet James Simmons
2015-05-22 18:32 ` [PATCH 1/6] staging:lustre:remove useless libcfs_sock_release James Simmons
2015-05-22 18:32 ` [PATCH 2/6] staging:lustre:remove useless libcfs_sock_abort_accept James Simmons
2015-05-22 18:32 ` [PATCH 3/6] staging:lustre: rename tcpip handling functions to lnet_* prefix James Simmons
2015-05-22 18:32 ` [PATCH 4/6] staging:lustre: use available kernel wrappers in lib-socket.c James Simmons
2015-05-22 18:32 ` [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c James Simmons
2015-05-25 9:37 ` Dan Carpenter
2015-05-27 15:01 ` Simmons, James A. [this message]
2015-05-27 15:24 ` [lustre-devel] " Dan Carpenter
2015-05-27 21:04 ` Simmons, James A.
2015-05-22 18:32 ` [PATCH 6/6] staging:lustre: Update license and copyright " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd9883629dd64028b5c4e6a33d17a431@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=HPDD-discuss@ml01.01.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®