Re: [PATCH v2 00/10] Expand SoundWire enumeration helper coverage

[Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>]

On 6/5/26 9:48 AM, Charles Keepax wrote:
> The patch series in [1] added a new helper to remove common boiler plate
> waiting for a device to enumerate on SoundWire, however, many devices
> also wait for enumeration during probe. This series updates things to be
> suitable such that we can call the same helper at probe time when the
> unattach_request is not valid.
> 
> There is one final step outstanding which is to add a core helper
> that waits for a device to drop off the bus. This is not include
> in this series and should be the last step of this process.
> 
> Thanks,
> Charles
> 
> [1] https://lore.kernel.org/linux-sound/20260512103022.1154645-1-ckeepax@opensource.cirrus.com/
> 
> Changes since v1:
>  - Completely remove the attached flag from cs42l43
> 
> Charles Keepax (10):
>   soundwire: Always wait for initialisation of unattached devices
>   ASoC: wsa881x: Use new SoundWire enumeration helper
>   mfd: cs42l43: Use new SoundWire enumeration helper
>   ASoC: rt5682: Use new SoundWire enumeration helper
>   ASoC: pm4125: Use new SoundWire enumeration helper
>   ASoC: wcd937x: Use new SoundWire enumeration helper
>   ASoC: wcd938x: Use new SoundWire enumeration helper
>   ASoC: wcd939x: Use new SoundWire enumeration helper
>   ASoC: SDCA: Use new SoundWire enumeration helper
>   ASoC: cs35l56: Remove unnecessary conditionals waiting for enumeration
> 
>  drivers/mfd/cs42l43-i2c.c      |  2 --
>  drivers/mfd/cs42l43-sdw.c      |  7 -----
>  drivers/mfd/cs42l43.c          | 15 ++++------
>  drivers/soundwire/bus.c        |  3 --
>  include/linux/mfd/cs42l43.h    |  2 --
>  sound/soc/codecs/cs35l56-sdw.c | 47 +++++++-----------------------
>  sound/soc/codecs/cs35l56.h     |  1 -

Thanks for the cleanup,

For all below Qualcomm codecs:
tested on Lenovo T14s.

>  sound/soc/codecs/pm4125.c      | 11 ++-----
>  sound/soc/codecs/wcd937x.c     | 11 ++-----
>  sound/soc/codecs/wcd938x.c     | 11 ++-----
>  sound/soc/codecs/wcd939x.c     | 11 ++-----
>  sound/soc/codecs/wsa881x.c     | 10 +++----

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>


--srini

>  sound/soc/sdca/sdca_class.c    | 53 ++++------------------------------
>  sound/soc/sdca/sdca_class.h    |  3 --
>  15 files changed, 41 insertions(+), 160 deletions(-)
>