[PATCH] slub: don't export static kmem_cache_open

[PATCH] slub: don't export static kmem_cache_open

[Johannes Berg]

kmem_cache_open is static so shouldn't be exported.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

---
 mm/slub.c |    1 -
 1 file changed, 1 deletion(-)

--- wireless-dev.orig/mm/slub.c	2007-07-05 11:35:51.555640003 +0200
+++ wireless-dev/mm/slub.c	2007-07-05 11:36:03.895640003 +0200
@@ -2016,7 +2016,6 @@ error:
 			s->offset, flags);
 	return 0;
 }
-EXPORT_SYMBOL(kmem_cache_open);
 
 /*
  * Check if a given pointer is valid

Re: [PATCH] slub: don't export static kmem_cache_open

[Christoph Lameter]

On Thu, 5 Jul 2007, Johannes Berg wrote:

> kmem_cache_open is static so shouldn't be exported.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

I already fixed that. Patch is in Andrew's tree.

Re: [PATCH] slub: don't export static kmem_cache_open

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

On Fri, 2007-07-06 at 10:29 -0700, Christoph Lameter wrote:
> On Thu, 5 Jul 2007, Johannes Berg wrote:
> 
> > kmem_cache_open is static so shouldn't be exported.
> > 
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> 
> I already fixed that. Patch is in Andrew's tree.

Oh good. I actually got build problems from that due to a powerpc64 gcc
bug so... :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH] slub: don't export static kmem_cache_open

[Christoph Lameter]

On Fri, 6 Jul 2007, Johannes Berg wrote:

> > I already fixed that. Patch is in Andrew's tree.
> 
> Oh good. I actually got build problems from that due to a powerpc64 gcc
> bug so... :)

Well in that case we may have to push the patch into 2.6.22 or stable.

Re: [PATCH] slub: don't export static kmem_cache_open

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

On Fri, 2007-07-06 at 10:55 -0700, Christoph Lameter wrote:
> On Fri, 6 Jul 2007, Johannes Berg wrote:
> 
> > > I already fixed that. Patch is in Andrew's tree.
> > 
> > Oh good. I actually got build problems from that due to a powerpc64 gcc
> > bug so... :)
> 
> Well in that case we may have to push the patch into 2.6.22 or stable.

Dunno. I had three such errors and have sent patches for all of them,
DaveM just accepted one, Paulus hasn't said anything yet and this was
the third. Olaf said the GCC PR is http://gcc.gnu.org/PR31490 and it
seems to fit.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH] slub: don't export static kmem_cache_open

[Bret Towe]

On 7/6/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Fri, 2007-07-06 at 10:29 -0700, Christoph Lameter wrote:
> > On Thu, 5 Jul 2007, Johannes Berg wrote:
> >
> > > kmem_cache_open is static so shouldn't be exported.
> > >
> > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> >
> > I already fixed that. Patch is in Andrew's tree.
>
> Oh good. I actually got build problems from that due to a powerpc64 gcc
> bug so... :)
>
> johannes
>
>

this also looks to solve booting issue on a g4 mac mini also

Re: [PATCH] slub: don't export static kmem_cache_open

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

On Fri, 2007-07-06 at 13:57 -0700, Bret Towe wrote:
> On 7/6/07, Johannes Berg <johannes@sipsolutions.net> wrote:

> > Oh good. I actually got build problems from that due to a powerpc64 gcc
> > bug so... :)

> this also looks to solve booting issue on a g4 mac mini also

Huh? That doesn't really make sense, but who knows what else that gcc
problem caused.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH] slub: don't export static kmem_cache_open

[Bret Towe]

On 7/6/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Fri, 2007-07-06 at 13:57 -0700, Bret Towe wrote:
> > On 7/6/07, Johannes Berg <johannes@sipsolutions.net> wrote:
>
> > > Oh good. I actually got build problems from that due to a powerpc64 gcc
> > > bug so... :)
>
> > this also looks to solve booting issue on a g4 mac mini also
>
> Huh? That doesn't really make sense, but who knows what else that gcc
> problem caused.
>
> johannes
>
>

if you want I can revert the patch and make sure thats what caused it
as when i applied this i also updated from cfs v18 to v19
but v18 was working fine before on rc7 i only updated to current -git

way I saw it was
-rc7-cfs-v18 working
-rc7-git-cfs-v18 broken booting with slub
-rc7-git-cfs-v19 working with slub with this patch