* [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code
@ 2025-08-19 12:11 Liao Yuanhong
2025-08-19 12:11 ` [PATCH 1/2] wifi: iwlwifi: Remove redundant header files Liao Yuanhong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-19 12:11 UTC (permalink / raw)
To: Miri Korenblit, Johannes Berg, Pagadala Yesu Anjaneyulu,
Emmanuel Grumbach, Somashekhar(Som),
Rotem Kerem, Yedidya Benshimol, Gregory Greenman,
open list:INTEL WIRELESS WIFI LINK (iwlwifi),
open list
Cc: Liao Yuanhong
There are two files with duplicate header files inclusions. Remove these
unnecessary header files to clean up the code.
Liao Yuanhong (2):
wifi: iwlwifi: Remove redundant header files
wifi: iwlwifi: pcie: Remove redundant header files
drivers/net/wireless/intel/iwlwifi/fw/regulatory.h | 1 -
drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c | 1 -
2 files changed, 2 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] wifi: iwlwifi: Remove redundant header files
2025-08-19 12:11 [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code Liao Yuanhong
@ 2025-08-19 12:11 ` Liao Yuanhong
2025-08-19 12:11 ` [PATCH 2/2] wifi: iwlwifi: pcie: " Liao Yuanhong
2025-08-19 16:35 ` [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code Markus Elfring
2 siblings, 0 replies; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-19 12:11 UTC (permalink / raw)
To: Miri Korenblit, Johannes Berg, Pagadala Yesu Anjaneyulu,
Emmanuel Grumbach, Somashekhar(Som),
Gregory Greenman, open list:INTEL WIRELESS WIFI LINK (iwlwifi),
open list
Cc: Liao Yuanhong
The header file "fw/img.h" is already included on line 9. Remove the
redundant include.
Fixes: 2594e4d9e1a2d ("wifi: iwlwifi: prepare for reading SAR tables from UEFI")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/net/wireless/intel/iwlwifi/fw/regulatory.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/regulatory.h b/drivers/net/wireless/intel/iwlwifi/fw/regulatory.h
index a07c512b6ed4..735482e7adf5 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/regulatory.h
+++ b/drivers/net/wireless/intel/iwlwifi/fw/regulatory.h
@@ -12,7 +12,6 @@
#include "fw/api/phy.h"
#include "fw/api/config.h"
#include "fw/api/nvm-reg.h"
-#include "fw/img.h"
#include "iwl-trans.h"
#define BIOS_SAR_MAX_PROFILE_NUM 4
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/2] wifi: iwlwifi: pcie: Remove redundant header files
2025-08-19 12:11 [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code Liao Yuanhong
2025-08-19 12:11 ` [PATCH 1/2] wifi: iwlwifi: Remove redundant header files Liao Yuanhong
@ 2025-08-19 12:11 ` Liao Yuanhong
2025-08-19 16:35 ` [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code Markus Elfring
2 siblings, 0 replies; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-19 12:11 UTC (permalink / raw)
To: Miri Korenblit, Johannes Berg, Emmanuel Grumbach, Rotem Kerem,
Yedidya Benshimol, open list:INTEL WIRELESS WIFI LINK (iwlwifi),
open list
Cc: Liao Yuanhong
The header file "fw/api/tx.h" is already included on line 26. Remove the
redundant include.
Fixes: 0b261b014a99f ("wifi: iwlwifi: pcie: Move txcmd size/align calculation to callers")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
index 327366bf87de..49237ffe8c88 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
@@ -25,7 +25,6 @@
#include "fw/dbg.h"
#include "fw/api/tx.h"
#include "fw/acpi.h"
-#include "fw/api/tx.h"
#include "mei/iwl-mei.h"
#include "internal.h"
#include "iwl-fh.h"
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code
2025-08-19 12:11 [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code Liao Yuanhong
2025-08-19 12:11 ` [PATCH 1/2] wifi: iwlwifi: Remove redundant header files Liao Yuanhong
2025-08-19 12:11 ` [PATCH 2/2] wifi: iwlwifi: pcie: " Liao Yuanhong
@ 2025-08-19 16:35 ` Markus Elfring
2 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2025-08-19 16:35 UTC (permalink / raw)
To: Liao Yuanhong, linux-wireless
Cc: LKML, Emmanuel Grumbach, Gregory Greenman, Johannes Berg,
Miri Korenblit, Pagadala Yesu Anjaneyulu, Rotem Kerem,
Somashekhar Puttagangaiah, Yedidya Benshimol
> There are two files with duplicate header files inclusions. Remove these
> unnecessary header files to clean up the code.
You would like to omit duplicate #include directives, don't you?
Will corresponding refinements become helpful for summary phrases
and change descriptions?
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-19 16:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-19 12:11 [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code Liao Yuanhong
2025-08-19 12:11 ` [PATCH 1/2] wifi: iwlwifi: Remove redundant header files Liao Yuanhong
2025-08-19 12:11 ` [PATCH 2/2] wifi: iwlwifi: pcie: " Liao Yuanhong
2025-08-19 16:35 ` [PATCH 0/2] wifi: iwlwifi: Remove redundant header files to clean code Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®