Re: [PATCH v3 5/8] x86/sev: Map only the RMP table entries instead of the full RMP range

[Tom Lendacky <thomas.lendacky@amd.com>]

On 10/17/24 23:38, Neeraj Upadhyay wrote:
> 
> 
> 
>>  /*
>>   * Do the necessary preparations which are verified by the firmware as
>>   * described in the SNP_INIT_EX firmware command description in the SNP
>> @@ -205,12 +222,17 @@ static int __init snp_rmptable_init(void)
>>  		goto nosnp;
>>  	}
>>  
>> -	rmptable_start = memremap(probed_rmp_base, probed_rmp_size, MEMREMAP_WB);
>> +	/* Map only the RMP entries */
>> +	rmptable_start = memremap(probed_rmp_base + RMPTABLE_CPU_BOOKKEEPING_SZ,
>> +				  probed_rmp_size - RMPTABLE_CPU_BOOKKEEPING_SZ,
>> +				  MEMREMAP_WB);
>>  	if (!rmptable_start) {
>>  		pr_err("Failed to map RMP table\n");
>>  		goto nosnp;
>>  	}
>>  
>> +	rmptable_size = probed_rmp_size - RMPTABLE_CPU_BOOKKEEPING_SZ;
>> +
> 
> Nit: Move this assignment above 'rmptable_start = memremap(...)', so that
> rmptable_size  can be used there.

I like the symmetry of the base and size adjustment in the memremap(). To
me it looks very obvious as to what is occurring.

Thanks,
Tom

> 
> 
> - Neeraj
>