[PATCH 1/1] media: xilinx: Use dmaengine_get_copy_align() accessor

[PATCH 1/1] media: xilinx: Use dmaengine_get_copy_align() accessor

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Replace direct access to dma->dma->device->copy_align with the
dmaengine_get_copy_align() accessor function.

Prepare move struct dma_device to private.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/media/platform/xilinx/xilinx-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/xilinx/xilinx-dma.c b/drivers/media/platform/xilinx/xilinx-dma.c
index ece2116639fc0..e01bb40bc39c7 100644
--- a/drivers/media/platform/xilinx/xilinx-dma.c
+++ b/drivers/media/platform/xilinx/xilinx-dma.c
@@ -710,7 +710,7 @@ int xvip_dma_init(struct xvip_composite_device *xdev, struct xvip_dma *dma,
 		goto error;
 	}
 
-	dma->align = 1 << dma->dma->device->copy_align;
+	dma->align = 1 << dmaengine_get_copy_align(dma->dma);
 
 	ret = video_register_device(&dma->video, VFL_TYPE_VIDEO, -1);
 	if (ret < 0) {
-- 
2.43.0

Re: [PATCH 1/1] media: xilinx: Use dmaengine_get_copy_align() accessor

[Laurent Pinchart]

On Wed, Nov 11, 2026 at 12:13:24PM -0500, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
> 
> Replace direct access to dma->dma->device->copy_align with the
> dmaengine_get_copy_align() accessor function.
> 
> Prepare move struct dma_device to private.

I didn't see a rationale in the commit that introduced
dmaengine_get_copy_align(), and I then saw it here. Without knowing much
about the greater plan of making dma_device private, this patch looks
OK.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Tomi, will you handle this with any other ongoing work on
media/platform/xilinx/, or should it get merged separately ?

> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  drivers/media/platform/xilinx/xilinx-dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-dma.c b/drivers/media/platform/xilinx/xilinx-dma.c
> index ece2116639fc0..e01bb40bc39c7 100644
> --- a/drivers/media/platform/xilinx/xilinx-dma.c
> +++ b/drivers/media/platform/xilinx/xilinx-dma.c
> @@ -710,7 +710,7 @@ int xvip_dma_init(struct xvip_composite_device *xdev, struct xvip_dma *dma,
>  		goto error;
>  	}
>  
> -	dma->align = 1 << dma->dma->device->copy_align;
> +	dma->align = 1 << dmaengine_get_copy_align(dma->dma);
>  
>  	ret = video_register_device(&dma->video, VFL_TYPE_VIDEO, -1);
>  	if (ret < 0) {

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/1] media: xilinx: Use dmaengine_get_copy_align() accessor

[Tomi Valkeinen]

Hi,

On 12/11/2026 01:15, Laurent Pinchart wrote:
> On Wed, Nov 11, 2026 at 12:13:24PM -0500, Frank.Li@oss.nxp.com wrote:
>> From: Frank Li <Frank.Li@nxp.com>
>>
>> Replace direct access to dma->dma->device->copy_align with the
>> dmaengine_get_copy_align() accessor function.
>>
>> Prepare move struct dma_device to private.
> 
> I didn't see a rationale in the commit that introduced
> dmaengine_get_copy_align(), and I then saw it here. Without knowing much
> about the greater plan of making dma_device private, this patch looks
> OK.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Tomi, will you handle this with any other ongoing work on
> media/platform/xilinx/, or should it get merged separately ?

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

This can be merged separately, I don't have any series that I would be 
sending in the near term future.

  Tomi


>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>>   drivers/media/platform/xilinx/xilinx-dma.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/xilinx/xilinx-dma.c b/drivers/media/platform/xilinx/xilinx-dma.c
>> index ece2116639fc0..e01bb40bc39c7 100644
>> --- a/drivers/media/platform/xilinx/xilinx-dma.c
>> +++ b/drivers/media/platform/xilinx/xilinx-dma.c
>> @@ -710,7 +710,7 @@ int xvip_dma_init(struct xvip_composite_device *xdev, struct xvip_dma *dma,
>>   		goto error;
>>   	}
>>   
>> -	dma->align = 1 << dma->dma->device->copy_align;
>> +	dma->align = 1 << dmaengine_get_copy_align(dma->dma);
>>   
>>   	ret = video_register_device(&dma->video, VFL_TYPE_VIDEO, -1);
>>   	if (ret < 0) {
>