From: Andrew Lunn <andrew@lunn.ch>
To: Matthew Gerlach <matthew.gerlach@altera.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
dinguyen@kernel.org, maxime.chevallier@bootlin.com,
richardcochran@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: socfpga: agilex5: enable gmac2 on the Agilex5 dev kit
Date: Mon, 14 Jul 2025 19:25:02 +0200 [thread overview]
Message-ID: <de1e4302-0262-4bcc-b324-49bfc2f5fd11@lunn.ch> (raw)
In-Reply-To: <20250714152528.311398-4-matthew.gerlach@altera.com>
> +&gmac2 {
> + status = "okay";
> + phy-mode = "rgmii"; /* Delays implemented by the IO ring of the Agilex5 SOCFPGA. */
Please could you explain in more details what this means.
The normal meaning for 'rgmii' is that the PCB implements the delay. I
just want to fully understand what this IO ring is, and if it is part
of the PCB.
> + phy-handle = <&emac2_phy0>;
> + max-frame-size = <9000>;
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + emac2_phy0: ethernet-phy@0 {
> + reg = <0>;
> + };
Please add a newline in here to separate the inner node from the
rest.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-07-14 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 15:25 [PATCH 0/4] arm64: dts: socfpga: enable ethernet support for Agilex5 Matthew Gerlach
2025-07-14 15:25 ` [PATCH 1/4] dt-bindings: net: altr,socfpga-stmmac: Add compatible string " Matthew Gerlach
2025-07-15 3:57 ` Rob Herring
2025-07-15 15:53 ` Matthew Gerlach
2025-07-14 15:25 ` [PATCH 2/4] arm64: dts: Agilex5 Add gmac nodes to DTSI " Matthew Gerlach
2025-07-14 15:25 ` [PATCH 3/4] arm64: dts: socfpga: agilex5: enable gmac2 on the Agilex5 dev kit Matthew Gerlach
2025-07-14 17:25 ` Andrew Lunn [this message]
2025-07-14 18:09 ` Matthew Gerlach
2025-07-14 18:52 ` Andrew Lunn
2025-07-14 22:29 ` Matthew Gerlach
2025-07-14 22:50 ` Andrew Lunn
2025-07-23 21:32 ` Matthew Gerlach
2025-07-14 22:57 ` Andrew Lunn
2025-07-14 15:25 ` [PATCH 4/4] net: stmmac: dwmac-socfpga: Add xgmac support for Agilex5 Matthew Gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1e4302-0262-4bcc-b324-49bfc2f5fd11@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthew.gerlach@altera.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®