From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Vinod Koul <vkoul@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe()
Date: Fri, 13 Sep 2024 19:39:10 +0200 [thread overview]
Message-ID: <de829772e1928cb5707fdae9cb72fe5885216db7.camel@gmail.com> (raw)
In-Reply-To: <459a965f-f49c-45b1-8362-5ac27b56f5ff@stanley.mountain>
Hi Dan,
thanks for fixing this!
On Fri, 2024-09-13 at 17:35 +0300, Dan Carpenter wrote:
> This was intended to be an IS_ERR() check, not a NULL check. The
> ep93xx_dma_of_probe() function doesn't return NULL pointers.
>
> Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> drivers/dma/ep93xx_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index d084bd123c1c..ca86b2b5a913 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
> int ret;
>
> edma = ep93xx_dma_of_probe(pdev);
> - if (!edma)
> + if (IS_ERR(edma))
> return PTR_ERR(edma);
>
> dma_dev = &edma->dma_dev;
--
Alexander Sverdlin.
prev parent reply other threads:[~2024-09-13 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 14:35 Dan Carpenter
2024-09-13 17:39 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de829772e1928cb5707fdae9cb72fe5885216db7.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®