* [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe()
@ 2024-09-13 14:35 Dan Carpenter
2024-09-13 17:39 ` Alexander Sverdlin
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-09-13 14:35 UTC (permalink / raw)
To: Nikita Shubin
Cc: Vinod Koul, Alexander Sverdlin, Arnd Bergmann, dmaengine,
linux-kernel, kernel-janitors
This was intended to be an IS_ERR() check, not a NULL check. The
ep93xx_dma_of_probe() function doesn't return NULL pointers.
Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/dma/ep93xx_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index d084bd123c1c..ca86b2b5a913 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
int ret;
edma = ep93xx_dma_of_probe(pdev);
- if (!edma)
+ if (IS_ERR(edma))
return PTR_ERR(edma);
dma_dev = &edma->dma_dev;
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe()
2024-09-13 14:35 [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe() Dan Carpenter
@ 2024-09-13 17:39 ` Alexander Sverdlin
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Sverdlin @ 2024-09-13 17:39 UTC (permalink / raw)
To: Dan Carpenter, Nikita Shubin
Cc: Vinod Koul, Arnd Bergmann, dmaengine, linux-kernel, kernel-janitors
Hi Dan,
thanks for fixing this!
On Fri, 2024-09-13 at 17:35 +0300, Dan Carpenter wrote:
> This was intended to be an IS_ERR() check, not a NULL check. The
> ep93xx_dma_of_probe() function doesn't return NULL pointers.
>
> Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> drivers/dma/ep93xx_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index d084bd123c1c..ca86b2b5a913 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
> int ret;
>
> edma = ep93xx_dma_of_probe(pdev);
> - if (!edma)
> + if (IS_ERR(edma))
> return PTR_ERR(edma);
>
> dma_dev = &edma->dma_dev;
--
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-13 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-13 14:35 [PATCH next] dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe() Dan Carpenter
2024-09-13 17:39 ` Alexander Sverdlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®