* [PATCH] ntb: idt: Remove redundant dev_err()
@ 2026-07-16 3:25 Pan Chuang
2026-07-16 17:06 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-16 3:25 UTC (permalink / raw)
To: Jon Mason, Dave Jiang, Allen Hubbe, Pan Chuang,
open list:NTB DRIVER CORE, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/ntb/hw/idt/ntb_hw_idt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
index f27df8d7f3b9..6793f7d4fc62 100644
--- a/drivers/ntb/hw/idt/ntb_hw_idt.c
+++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
@@ -2141,10 +2141,8 @@ static int idt_init_isr(struct idt_ntb_dev *ndev)
/* Set the IRQ handler */
ret = devm_request_threaded_irq(&pdev->dev, ret, NULL, idt_thread_isr,
IRQF_ONESHOT, NTB_IRQNAME, ndev);
- if (ret != 0) {
- dev_err(&pdev->dev, "Failed to set MSI IRQ handler, %d", ret);
+ if (ret != 0)
goto err_free_vectors;
- }
/* Unmask Message/Doorbell/SE interrupts */
ntint_mask = idt_nt_read(ndev, IDT_NT_NTINTMSK) & ~IDT_NTINTMSK_ALL;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ntb: idt: Remove redundant dev_err()
2026-07-16 3:25 [PATCH] ntb: idt: Remove redundant dev_err() Pan Chuang
@ 2026-07-16 17:06 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2026-07-16 17:06 UTC (permalink / raw)
To: Pan Chuang, Jon Mason, Allen Hubbe, open list:NTB DRIVER CORE, open list
On 7/15/26 8:25 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/hw/idt/ntb_hw_idt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index f27df8d7f3b9..6793f7d4fc62 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -2141,10 +2141,8 @@ static int idt_init_isr(struct idt_ntb_dev *ndev)
> /* Set the IRQ handler */
> ret = devm_request_threaded_irq(&pdev->dev, ret, NULL, idt_thread_isr,
> IRQF_ONESHOT, NTB_IRQNAME, ndev);
> - if (ret != 0) {
> - dev_err(&pdev->dev, "Failed to set MSI IRQ handler, %d", ret);
> + if (ret != 0)
> goto err_free_vectors;
> - }
>
> /* Unmask Message/Doorbell/SE interrupts */
> ntint_mask = idt_nt_read(ndev, IDT_NT_NTINTMSK) & ~IDT_NTINTMSK_ALL;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-16 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-16 3:25 [PATCH] ntb: idt: Remove redundant dev_err() Pan Chuang
2026-07-16 17:06 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®