From: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
To: Sergey Lebedev <lsa.uz@pm.me>, George Neacsu <geocausa@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dan Scally <dan.scally@ideasonboard.com>,
Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Marshall <pm@petermarshall.ca>,
"Hao Yao" <hao.yao@intel.com>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver
Date: Tue, 20 Oct 2026 14:25:46 +0200 [thread overview]
Message-ID: <de8c6003-c7b5-40f0-beab-4c3370b98f09@foss.st.com> (raw)
In-Reply-To: <20261020085200.60619-1-lsa.uz@pm.me>
Hi,
Le 20/10/2026 à 10:52, Sergey Lebedev a écrit :
> Hi George,
>
> On 20/10/2026 07:44, George Neacsu wrote:
>> Would you be comfortable dropping that write in the next revision? I can
>> retest the revision on the Snapdragon model and add a Tested-by once it
>> is clean.
>
> Yes, I will drop that write in v2 and leave 0x0329 at its default, and
> Cc you on it. Thank you for narrowing it down to one line.
>
> On the Intel model it makes no difference. In one boot, with the sensor
> held powered and 0x0329 set to 1, then 0, then 1 again, each state
> streamed 150 of 150 frames at 59.14 fps and restarted 10 of 10 times.
> The test-pattern frames showed no shift or extra lines in any state, so
> IPU7 does not put the status lines into the buffer, and its error
> count did not change. The full test run without the write
> matches the run with it, v4l2-compliance 46 of 46 included.
>
> One thing I cannot explain: on 16/10 your vd55g1 build streamed 2/2
> with 0x0329 = 0 written once per power-on, as v1 does it. So the write
> alone may not be what stops CAMSS; something else in v1 may take part.
> Leaving the register alone is simpler either way.
I'm a bit puzzled on this.
ISL are output on a different data type than regular data. They are
output with 0x12, which translates to MIPI_CSI2_DT_EMBEDDED_8B in V4L2.
Your receiver should drop these frames regardless as it only waits for
data and not ISL. Outputting them doesn't affect sensor timings either.
I guess there could be an issue on the receiver side ? Maybe your
receiver is ignoring data types and completes the frame with ISL data,
effectively filling up the DMA ?
>
> Sergey
--
Regards,
Benjamin
next prev parent reply other threads:[~2026-10-20 12:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 16:27 [PATCH 0/4] media: Add the ST VD55G0 global shutter sensor Sergey Lebedev
2026-10-19 16:27 ` [PATCH 1/4] dt-bindings: media: i2c: Add ST VD55G0 camera sensor Sergey Lebedev
2026-10-20 8:27 ` Krzysztof Kozlowski
2026-10-20 9:08 ` Sergey Lebedev
2026-10-19 16:27 ` [PATCH 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver Sergey Lebedev
2026-10-19 18:24 ` George Neacsu
2026-10-19 19:34 ` Sergey Lebedev
2026-10-20 6:44 ` George Neacsu
2026-10-20 8:52 ` Sergey Lebedev
2026-10-20 12:25 ` Benjamin Mugnier [this message]
2026-10-20 14:26 ` Sergey Lebedev
2026-10-20 18:10 ` George Neacsu
2026-10-20 18:14 ` Sergey Lebedev
2026-10-19 16:28 ` [PATCH 3/4] media: ipu-bridge: Add ST VD55G0 Sergey Lebedev
2026-10-19 16:28 ` [PATCH 4/4] media: ipu-bridge: Add the Surface Pro 11 infrared illuminator Sergey Lebedev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8c6003-c7b5-40f0-beab-4c3370b98f09@foss.st.com \
--to=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geocausa@gmail.com \
--cc=hansg@kernel.org \
--cc=hao.yao@intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lsa.uz@pm.me \
--cc=mchehab@kernel.org \
--cc=pm@petermarshall.ca \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®