From: George Neacsu <geocausa@gmail.com>
To: Sergey Lebedev <lsa.uz@pm.me>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dan Scally <dan.scally@ideasonboard.com>,
Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Marshall <pm@petermarshall.ca>, Hao Yao <hao.yao@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver
Date: Tue, 20 Oct 2026 19:10:25 +0100 [thread overview]
Message-ID: <20261020181025.8625-1-geocausa@gmail.com> (raw)
In-Reply-To: <20261020142641.24808-1-lsa.uz@pm.me>
Hi Benjamin, Sergey,
On 20/10/2026 15:26, Sergey Lebedev wrote:
> So I agree the register itself
> should not matter there; something else in v1 probably does, and George
> can narrow it down on CAMSS better than I can.
You were both right, and I have to correct my earlier report.
I looked at the receiver side with a CSID change that only reads
registers at stream start. RDI0 is set up for data type 0x2b (RAW10),
VC 0, with no ECC or CRC errors, so CAMSS filters on the data type and
the ISL lines (DT 0x12) should not reach the buffer.
With that in place I reran the exact v1 module that stalled this morning:
same build, 403.2 MHz in the DT, and the ISL_ENABLE=0 write still in. It
streamed 5/5 frames, 120/120 at about 60.2 fps, and 10/10 on an
immediate restart. Builds that wrote 0 and builds that left the default
behaved the same, and read back 0x00 and 0x01 respectively.
To rule out the diagnostic reads changing the timing, I then booted
again with the unmodified CAMSS module and the same exact v1 module:
three rounds of 5, 120 and 10 frames, all complete, at about 60.2 fps,
with no CAMSS errors.
So clearing 0x0329 does not cause the stall on this machine. My earlier
A/B was a correlation, not the cause; something else in those runs made
the difference, and I have not pinned it down yet.
I tried to count the DT 0x12 packets directly with the CSID's
long-packet capture, but enabling that capture changed the behaviour
itself (one frame only), so it could not serve as a passive observer.
Sergey, the write can stay or go as you prefer; the Snapdragon model
does not need it dropped. The 403.2 MHz link frequency still stands.
I will test v2 on the X1E80100 and send a Tested-by if it passes.
Sorry for the noise.
Thanks,
George
next prev parent reply other threads:[~2026-10-20 18:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 16:27 [PATCH 0/4] media: Add the ST VD55G0 global shutter sensor Sergey Lebedev
2026-10-19 16:27 ` [PATCH 1/4] dt-bindings: media: i2c: Add ST VD55G0 camera sensor Sergey Lebedev
2026-10-20 8:27 ` Krzysztof Kozlowski
2026-10-20 9:08 ` Sergey Lebedev
2026-10-19 16:27 ` [PATCH 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver Sergey Lebedev
2026-10-19 18:24 ` George Neacsu
2026-10-19 19:34 ` Sergey Lebedev
2026-10-20 6:44 ` George Neacsu
2026-10-20 8:52 ` Sergey Lebedev
2026-10-20 12:25 ` Benjamin Mugnier
2026-10-20 14:26 ` Sergey Lebedev
2026-10-20 18:10 ` George Neacsu [this message]
2026-10-20 18:14 ` Sergey Lebedev
2026-10-21 9:02 ` Benjamin Mugnier
2026-10-21 9:04 ` Benjamin Mugnier
2026-10-21 9:06 ` Sergey Lebedev
2026-10-19 16:28 ` [PATCH 3/4] media: ipu-bridge: Add ST VD55G0 Sergey Lebedev
2026-10-19 16:28 ` [PATCH 4/4] media: ipu-bridge: Add the Surface Pro 11 infrared illuminator Sergey Lebedev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020181025.8625-1-geocausa@gmail.com \
--to=geocausa@gmail.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=hao.yao@intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lsa.uz@pm.me \
--cc=mchehab@kernel.org \
--cc=pm@petermarshall.ca \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®