From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Swati Agarwal <swati.agarwal@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: monaco-evk: Enable GPIO expander interrupt for Monaco EVK
Date: Tue, 3 Mar 2026 10:59:46 +0100 [thread overview]
Message-ID: <dea48c89-6718-49b0-ac4e-840e596d0166@oss.qualcomm.com> (raw)
In-Reply-To: <20260303082157.523847-2-swati.agarwal@oss.qualcomm.com>
On 3/3/26 9:21 AM, Swati Agarwal wrote:
> Enable PCA9538 expander as interrupt controller on Monaco EVK and configure
> the corresponding TLMM pins via pinctrl to operate as GPIO inputs with
> internal pull-ups.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> ---
[...]
> &tlmm {
>
> +
Stray \n above
expander0_int: expander0-int-state {
> + pins = "gpio56";
The TLMM entries are currently ordered by the pin index - please retain
that.
Otherwise, this looks good
Konrad
next prev parent reply other threads:[~2026-03-03 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:21 [PATCH v2 0/3] Enable secondary USB controller in OTG mode Swati Agarwal
2026-03-03 8:21 ` [PATCH v2 1/3] arm64: dts: qcom: monaco-evk: Enable GPIO expander interrupt for Monaco EVK Swati Agarwal
2026-03-03 9:59 ` Konrad Dybcio [this message]
2026-03-06 10:04 ` Swati Agarwal
2026-03-03 8:21 ` [PATCH v2 2/3] arm64: dts: qcom: monaco: Add role-switch support and HS endpoint for secondary USB controller Swati Agarwal
2026-03-03 10:00 ` Konrad Dybcio
2026-03-04 3:57 ` Dmitry Baryshkov
2026-03-03 8:21 ` [PATCH v2 3/3] arm64: dts: qcom: monaco-evk: Enable the " Swati Agarwal
2026-03-03 10:00 ` Konrad Dybcio
2026-03-04 4:17 ` Dmitry Baryshkov
2026-03-10 2:45 ` [PATCH v2 0/3] Enable secondary USB controller in OTG mode Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dea48c89-6718-49b0-ac4e-840e596d0166@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=swati.agarwal@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®