mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] k3-am64: Set MMC CLK pins as output
@ 2026-09-28  3:30 Sai Sree Kartheek Adivi
  2026-09-28  3:30 ` [PATCH 1/2] arm64: dts: ti: k3-am64: Drop MMC CLKLB config Sai Sree Kartheek Adivi
  2026-09-28  3:30 ` [PATCH 2/2] arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT Sai Sree Kartheek Adivi
  0 siblings, 2 replies; 5+ messages in thread
From: Sai Sree Kartheek Adivi @ 2026-09-28  3:30 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, linux-arm-kernel,
	devicetree, linux-kernel, s-adivi
  Cc: hnagalla, jm

This patch series sets the MMC CLK pins to output mode
according to TRM specifictations on MMCSDi I/O Signals.
It also fixes some issue with MMC CLKLB pin configuration

Judith Mendez (2):
  arm64: dts: ti: k3-am64: Drop MMC CLKLB config
  arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT

 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 3 +--
 arch/arm64/boot/dts/ti/k3-am642-sk.dts  | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] arm64: dts: ti: k3-am64: Drop MMC CLKLB config
  2026-09-28  3:30 [PATCH 0/2] k3-am64: Set MMC CLK pins as output Sai Sree Kartheek Adivi
@ 2026-09-28  3:30 ` Sai Sree Kartheek Adivi
  2026-09-28  3:30 ` [PATCH 2/2] arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT Sai Sree Kartheek Adivi
  1 sibling, 0 replies; 5+ messages in thread
From: Sai Sree Kartheek Adivi @ 2026-09-28  3:30 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, linux-arm-kernel,
	devicetree, linux-kernel, s-adivi
  Cc: hnagalla, jm

From: Judith Mendez <jm@ti.com>

MMC CLKLB pins should be left at default state since it is set
to the correct default values after reset on the supported
sillicon versions.

Signed-off-by: Judith Mendez <jm@ti.com>
Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 1 -
 arch/arm64/boot/dts/ti/k3-am642-sk.dts  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index bc4347cf71140..a8c256269859e 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -260,7 +260,6 @@ AM64X_IOPAD(0x0280, PIN_INPUT_PULLUP, 0) /* (K19) MMC1_DAT2 */
 			AM64X_IOPAD(0x027c, PIN_INPUT_PULLUP, 0) /* (K18) MMC1_DAT3 */
 			AM64X_IOPAD(0x0298, PIN_INPUT_PULLUP, 0) /* (D19) MMC1_SDCD */
 			AM64X_IOPAD(0x029c, PIN_INPUT, 0) /* (C20) MMC1_SDWP */
-			AM64X_IOPAD(0x0290, PIN_INPUT, 0) /* MMC1_CLKLB */
 		>;
 	};
 
diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index d28a38c87f32a..6b50997780448 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -201,7 +201,6 @@ main_mmc1_pins_default: main-mmc1-default-pins {
 			AM64X_IOPAD(0x029c, PIN_INPUT_PULLUP, 0) /* (C20) MMC1_SDWP */
 			AM64X_IOPAD(0x0298, PIN_INPUT_PULLUP, 0) /* (D19) MMC1_SDCD */
 			AM64X_IOPAD(0x0294, PIN_INPUT_PULLUP, 0) /* (J19) MMC1_CMD */
-			AM64X_IOPAD(0x0290, PIN_INPUT, 0) /* (#N/A) MMC1_CLKLB */
 			AM64X_IOPAD(0x028c, PIN_INPUT_PULLDOWN, 0) /* (L20) MMC1_CLK */
 			AM64X_IOPAD(0x0288, PIN_INPUT_PULLUP, 0) /* (K21) MMC1_DAT0 */
 			AM64X_IOPAD(0x0284, PIN_INPUT_PULLUP, 0) /* (L21) MMC1_DAT1 */
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT
  2026-09-28  3:30 [PATCH 0/2] k3-am64: Set MMC CLK pins as output Sai Sree Kartheek Adivi
  2026-09-28  3:30 ` [PATCH 1/2] arm64: dts: ti: k3-am64: Drop MMC CLKLB config Sai Sree Kartheek Adivi
@ 2026-09-28  3:30 ` Sai Sree Kartheek Adivi
  2026-09-28 17:00   ` Judith Mendez
  1 sibling, 1 reply; 5+ messages in thread
From: Sai Sree Kartheek Adivi @ 2026-09-28  3:30 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, linux-arm-kernel,
	devicetree, linux-kernel, s-adivi
  Cc: hnagalla, jm

From: Judith Mendez <jm@ti.com>

MMC clock pins must be configured as OUTPUT-only per TRM specification [0]
with receiver disabled (RXACTIVE bit = 0). Change MMC1_CLK from PIN_INPUT
to PIN_OUTPUT in AM64 device trees to match documentation.

[0] https://www.ti.com/lit/pdf/spruim2 Rev. J: Table 12-327. MMCSDi I/O Signals
Signed-off-by: Judith Mendez <jm@ti.com>
Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +-
 arch/arm64/boot/dts/ti/k3-am642-sk.dts  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index a8c256269859e..677b7ec7c7dae 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -253,7 +253,7 @@ &main_pmx0 {
 	main_mmc1_pins_default: main-mmc1-default-pins {
 		pinctrl-single,pins = <
 			AM64X_IOPAD(0x0294, PIN_INPUT_PULLUP, 0) /* (J19) MMC1_CMD */
-			AM64X_IOPAD(0x028c, PIN_INPUT_PULLDOWN, 0) /* (L20) MMC1_CLK */
+			AM64X_IOPAD(0x028c, PIN_OUTPUT, 0) /* (L20) MMC1_CLK */
 			AM64X_IOPAD(0x0288, PIN_INPUT_PULLUP, 0) /* (K21) MMC1_DAT0 */
 			AM64X_IOPAD(0x0284, PIN_INPUT_PULLUP, 0) /* (L21) MMC1_DAT1 */
 			AM64X_IOPAD(0x0280, PIN_INPUT_PULLUP, 0) /* (K19) MMC1_DAT2 */
diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index 6b50997780448..ea85be05a4111 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -201,7 +201,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
 			AM64X_IOPAD(0x029c, PIN_INPUT_PULLUP, 0) /* (C20) MMC1_SDWP */
 			AM64X_IOPAD(0x0298, PIN_INPUT_PULLUP, 0) /* (D19) MMC1_SDCD */
 			AM64X_IOPAD(0x0294, PIN_INPUT_PULLUP, 0) /* (J19) MMC1_CMD */
-			AM64X_IOPAD(0x028c, PIN_INPUT_PULLDOWN, 0) /* (L20) MMC1_CLK */
+			AM64X_IOPAD(0x028c, PIN_OUTPUT, 0) /* (L20) MMC1_CLK */
 			AM64X_IOPAD(0x0288, PIN_INPUT_PULLUP, 0) /* (K21) MMC1_DAT0 */
 			AM64X_IOPAD(0x0284, PIN_INPUT_PULLUP, 0) /* (L21) MMC1_DAT1 */
 			AM64X_IOPAD(0x0280, PIN_INPUT_PULLUP, 0) /* (K19) MMC1_DAT2 */
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT
  2026-09-28  3:30 ` [PATCH 2/2] arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT Sai Sree Kartheek Adivi
@ 2026-09-28 17:00   ` Judith Mendez
  2026-09-28 17:46     ` Judith Mendez
  0 siblings, 1 reply; 5+ messages in thread
From: Judith Mendez @ 2026-09-28 17:00 UTC (permalink / raw)
  To: Sai Sree Kartheek Adivi, nm, vigneshr, kristo, robh, krzk+dt,
	conor+dt, linux-arm-kernel, devicetree, linux-kernel
  Cc: hnagalla

Hi Sai,

On 9/27/26 10:30 PM, Sai Sree Kartheek Adivi wrote:
> From: Judith Mendez <jm@ti.com>
> 
> MMC clock pins must be configured as OUTPUT-only per TRM specification [0]
> with receiver disabled (RXACTIVE bit = 0). Change MMC1_CLK from PIN_INPUT
> to PIN_OUTPUT in AM64 device trees to match documentation.

There was an issue showing up in automated testing that I was not sure
if it was attributed to this patch series. So I was waiting to see the
error again to debug. Not 100% confident this should go upstream yet.

~ Judith

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT
  2026-09-28 17:00   ` Judith Mendez
@ 2026-09-28 17:46     ` Judith Mendez
  0 siblings, 0 replies; 5+ messages in thread
From: Judith Mendez @ 2026-09-28 17:46 UTC (permalink / raw)
  To: Sai Sree Kartheek Adivi, nm, vigneshr, kristo, robh, krzk+dt,
	conor+dt, linux-arm-kernel, devicetree, linux-kernel
  Cc: hnagalla

Sai,

On 9/28/26 12:00 PM, Judith Mendez wrote:
> Hi Sai,
> 
> On 9/27/26 10:30 PM, Sai Sree Kartheek Adivi wrote:
>> From: Judith Mendez <jm@ti.com>
>>
>> MMC clock pins must be configured as OUTPUT-only per TRM specification 
>> [0]
>> with receiver disabled (RXACTIVE bit = 0). Change MMC1_CLK from PIN_INPUT
>> to PIN_OUTPUT in AM64 device trees to match documentation.
> 
> There was an issue showing up in automated testing that I was not sure
> if it was attributed to this patch series. So I was waiting to see the
> error again to debug. Not 100% confident this should go upstream yet.

On top to this, this change also needs to be added for all AM64 based
boards. But as said before, I think we need to wait a bit before
sending this patch (:

~ Judith

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-28 17:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-28  3:30 [PATCH 0/2] k3-am64: Set MMC CLK pins as output Sai Sree Kartheek Adivi
2026-09-28  3:30 ` [PATCH 1/2] arm64: dts: ti: k3-am64: Drop MMC CLKLB config Sai Sree Kartheek Adivi
2026-09-28  3:30 ` [PATCH 2/2] arm64: dts: ti: k3-am64: Set MMC1_CLK pin as OUTPUT Sai Sree Kartheek Adivi
2026-09-28 17:00   ` Judith Mendez
2026-09-28 17:46     ` Judith Mendez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®