* [PATCH] drm/nouveau/nvkm: do not use assignment in if condition
[not found] <20230710032131.52747-1-xujianghui@cdjrlc.com>
@ 2023-07-10 4:07 ` sunran001
2023-07-13 9:11 ` Karol Herbst
0 siblings, 1 reply; 2+ messages in thread
From: sunran001 @ 2023-07-10 4:07 UTC (permalink / raw)
To: airlied, daniel; +Cc: dri-devel, nouveau, linux-kernel
Assignments in if condition are less readable and error-prone. Fixes
also checkpatch warning:
ERROR: do not use assignment in if condition
Signed-off-by:Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
index 976539de4220..054fa42f1d04 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
@@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func,
struct nvkm_device *device,
if (ccbE.share != DCB_I2C_UNUSED) {
const int id = NVKM_I2C_PAD_HYBRID(ccbE.share);
- if (!(pad = nvkm_i2c_pad_find(i2c, id)))
+ pad = nvkm_i2c_pad_find(i2c, id);
+ if (!pad)
ret = func->pad_s_new(i2c, id, &pad);
else
ret = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/nouveau/nvkm: do not use assignment in if condition
2023-07-10 4:07 ` [PATCH] drm/nouveau/nvkm: do not use assignment in if condition sunran001
@ 2023-07-13 9:11 ` Karol Herbst
0 siblings, 0 replies; 2+ messages in thread
From: Karol Herbst @ 2023-07-13 9:11 UTC (permalink / raw)
To: sunran001; +Cc: airlied, daniel, nouveau, linux-kernel, dri-devel
On Mon, Jul 10, 2023 at 9:23 AM <sunran001@208suo.com> wrote:
>
> Assignments in if condition are less readable and error-prone. Fixes
> also checkpatch warning:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by:Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> index 976539de4220..054fa42f1d04 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> @@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func,
> struct nvkm_device *device,
>
> if (ccbE.share != DCB_I2C_UNUSED) {
> const int id = NVKM_I2C_PAD_HYBRID(ccbE.share);
> - if (!(pad = nvkm_i2c_pad_find(i2c, id)))
> + pad = nvkm_i2c_pad_find(i2c, id);
> + if (!pad)
> ret = func->pad_s_new(i2c, id, &pad);
> else
> ret = 0;
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-13 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230710032131.52747-1-xujianghui@cdjrlc.com>
2023-07-10 4:07 ` [PATCH] drm/nouveau/nvkm: do not use assignment in if condition sunran001
2023-07-13 9:11 ` Karol Herbst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®