From: Martin Kepplinger <martink@posteo.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Florian Echtler <floe@butterbrot.org>,
Johan Hovold <johan@kernel.org>,
Martin Kaltenbrunner <modin@yuri.at>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: sur40: Delete an error message for a failed memory allocation in sur40_probe()
Date: Mon, 22 Jan 2018 08:00:24 +0100 [thread overview]
Message-ID: <dee45f67-7cf6-1b51-9735-4cfc5c68d610@posteo.de> (raw)
In-Reply-To: <122986b6-b7f2-9b34-b11d-4d63557a2b97@users.sourceforge.net>
On 2018-01-20 22:28, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 Jan 2018 22:11:24 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/input/touchscreen/sur40.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index f16f8358c70a..c7a0a92b2044 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -591,7 +591,6 @@ static int sur40_probe(struct usb_interface *interface,
> sur40->bulk_in_epaddr = endpoint->bEndpointAddress;
> sur40->bulk_in_buffer = kmalloc(sur40->bulk_in_size, GFP_KERNEL);
> if (!sur40->bulk_in_buffer) {
> - dev_err(&interface->dev, "Unable to allocate input buffer.");
> error = -ENOMEM;
> goto err_free_polldev;
> }
>
next prev parent reply other threads:[~2018-01-22 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 21:26 [PATCH 0/2] Input-sur40: Adjustments for sur40_probe() SF Markus Elfring
2018-01-20 21:28 ` [PATCH 1/2] Input: sur40: Delete an error message for a failed memory allocation in sur40_probe() SF Markus Elfring
2018-01-22 7:00 ` Martin Kepplinger [this message]
2018-01-20 21:30 ` [PATCH 2/2] Input: sur40: Improve a size determination " SF Markus Elfring
2018-01-22 7:02 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dee45f67-7cf6-1b51-9735-4cfc5c68d610@posteo.de \
--to=martink@posteo.de \
--cc=dmitry.torokhov@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=floe@butterbrot.org \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=modin@yuri.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®