From: Caleb Connolly <caleb.connolly@linaro.org>
To: Sachin Gupta <quic_sachgupt@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_nitirawa@quicinc.com,
quic_bhaskarv@quicinc.com, quic_narepall@quicinc.com,
quic_rampraka@quicinc.com, quic_sartgarg@quicinc.com,
quic_mapa@quicinc.com, quic_cang@quicinc.com,
quic_nguyenb@quicinc.com
Subject: Re: [PATCH V3] arm64: dts: qcom: Add SD Card node for qcm6490-idp
Date: Fri, 30 Aug 2024 11:03:05 +0100 [thread overview]
Message-ID: <df059de8-0240-43d4-8d9e-c0b113db47d2@linaro.org> (raw)
In-Reply-To: <20240829121225.14184-1-quic_sachgupt@quicinc.com>
Hi Sachin,
Thanks for the patch
On 29/08/2024 13:12, Sachin Gupta wrote:
> Add SD Card node for Qualcomm qcm6490-idp Board.
>
> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
> ---
> Changes from v2:
> - Corrected patch version.
>
> Changes from v1:
> - Define sd_cd node. (Thanks Dmitry)
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 33 ++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index a0668f767e4b..95d5cf2d9bcd 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -641,6 +641,21 @@
> status = "okay";
> };
>
> +&sdc2_clk {
> + bias-disable;
> + drive-strength = <16>;
> +};
> +
> +&sdc2_cmd {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> +&sdc2_data {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> &sdhc_1 {
> non-removable;
> no-sd;
> @@ -655,12 +670,30 @@
> &tlmm {
> gpio-reserved-ranges = <32 2>, /* ADSP */
> <48 4>; /* NFC */
> +
> + sd_cd: sd-cd-state {
> + pins = "gpio91";
> + function = "gpio";
> + bias-pull-up;
> + };
> };
>
> &uart5 {
> status = "okay";
> };
>
> +&sdhc_2 {
Alphabetical order please! This should go after sdhc_1
With that fix, please add
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Thanks and regards,
> + status = "okay";
> +
> + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>, <&sd_cd>;
> + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>, <&sd_cd>;
> +
> + vmmc-supply = <&vreg_l9c_2p96>;
> + vqmmc-supply = <&vreg_l6c_2p96>;
> +
> + cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
> +};
> +
> &usb_1 {
> status = "okay";
> };
--
// Caleb (they/them)
prev parent reply other threads:[~2024-08-30 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 12:12 Sachin Gupta
2024-08-30 7:17 ` Dmitry Baryshkov
2024-08-30 10:03 ` Caleb Connolly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df059de8-0240-43d4-8d9e-c0b113db47d2@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_mapa@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sachgupt@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®