* [PATCH V3] arm64: dts: qcom: Add SD Card node for qcm6490-idp
@ 2024-08-29 12:12 Sachin Gupta
2024-08-30 7:17 ` Dmitry Baryshkov
2024-08-30 10:03 ` Caleb Connolly
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Gupta @ 2024-08-29 12:12 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_nitirawa,
quic_bhaskarv, quic_narepall, quic_rampraka, quic_sartgarg,
quic_mapa, quic_cang, quic_nguyenb
Add SD Card node for Qualcomm qcm6490-idp Board.
Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
---
Changes from v2:
- Corrected patch version.
Changes from v1:
- Define sd_cd node. (Thanks Dmitry)
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 33 ++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index a0668f767e4b..95d5cf2d9bcd 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -641,6 +641,21 @@
status = "okay";
};
+&sdc2_clk {
+ bias-disable;
+ drive-strength = <16>;
+};
+
+&sdc2_cmd {
+ bias-pull-up;
+ drive-strength = <10>;
+};
+
+&sdc2_data {
+ bias-pull-up;
+ drive-strength = <10>;
+};
+
&sdhc_1 {
non-removable;
no-sd;
@@ -655,12 +670,30 @@
&tlmm {
gpio-reserved-ranges = <32 2>, /* ADSP */
<48 4>; /* NFC */
+
+ sd_cd: sd-cd-state {
+ pins = "gpio91";
+ function = "gpio";
+ bias-pull-up;
+ };
};
&uart5 {
status = "okay";
};
+&sdhc_2 {
+ status = "okay";
+
+ pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>, <&sd_cd>;
+ pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>, <&sd_cd>;
+
+ vmmc-supply = <&vreg_l9c_2p96>;
+ vqmmc-supply = <&vreg_l6c_2p96>;
+
+ cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
+};
+
&usb_1 {
status = "okay";
};
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V3] arm64: dts: qcom: Add SD Card node for qcm6490-idp
2024-08-29 12:12 [PATCH V3] arm64: dts: qcom: Add SD Card node for qcm6490-idp Sachin Gupta
@ 2024-08-30 7:17 ` Dmitry Baryshkov
2024-08-30 10:03 ` Caleb Connolly
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-08-30 7:17 UTC (permalink / raw)
To: Sachin Gupta
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
quic_nitirawa, quic_bhaskarv, quic_narepall, quic_rampraka,
quic_sartgarg, quic_mapa, quic_cang, quic_nguyenb
On Thu, Aug 29, 2024 at 05:42:25PM GMT, Sachin Gupta wrote:
> Add SD Card node for Qualcomm qcm6490-idp Board.
>
> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
> ---
> Changes from v2:
> - Corrected patch version.
In future: no need to resend for such small issues.
>
> Changes from v1:
> - Define sd_cd node. (Thanks Dmitry)
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 33 ++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] arm64: dts: qcom: Add SD Card node for qcm6490-idp
2024-08-29 12:12 [PATCH V3] arm64: dts: qcom: Add SD Card node for qcm6490-idp Sachin Gupta
2024-08-30 7:17 ` Dmitry Baryshkov
@ 2024-08-30 10:03 ` Caleb Connolly
1 sibling, 0 replies; 3+ messages in thread
From: Caleb Connolly @ 2024-08-30 10:03 UTC (permalink / raw)
To: Sachin Gupta, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_nitirawa,
quic_bhaskarv, quic_narepall, quic_rampraka, quic_sartgarg,
quic_mapa, quic_cang, quic_nguyenb
Hi Sachin,
Thanks for the patch
On 29/08/2024 13:12, Sachin Gupta wrote:
> Add SD Card node for Qualcomm qcm6490-idp Board.
>
> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
> ---
> Changes from v2:
> - Corrected patch version.
>
> Changes from v1:
> - Define sd_cd node. (Thanks Dmitry)
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 33 ++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index a0668f767e4b..95d5cf2d9bcd 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -641,6 +641,21 @@
> status = "okay";
> };
>
> +&sdc2_clk {
> + bias-disable;
> + drive-strength = <16>;
> +};
> +
> +&sdc2_cmd {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> +&sdc2_data {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> &sdhc_1 {
> non-removable;
> no-sd;
> @@ -655,12 +670,30 @@
> &tlmm {
> gpio-reserved-ranges = <32 2>, /* ADSP */
> <48 4>; /* NFC */
> +
> + sd_cd: sd-cd-state {
> + pins = "gpio91";
> + function = "gpio";
> + bias-pull-up;
> + };
> };
>
> &uart5 {
> status = "okay";
> };
>
> +&sdhc_2 {
Alphabetical order please! This should go after sdhc_1
With that fix, please add
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Thanks and regards,
> + status = "okay";
> +
> + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>, <&sd_cd>;
> + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>, <&sd_cd>;
> +
> + vmmc-supply = <&vreg_l9c_2p96>;
> + vqmmc-supply = <&vreg_l6c_2p96>;
> +
> + cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
> +};
> +
> &usb_1 {
> status = "okay";
> };
--
// Caleb (they/them)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-30 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-29 12:12 [PATCH V3] arm64: dts: qcom: Add SD Card node for qcm6490-idp Sachin Gupta
2024-08-30 7:17 ` Dmitry Baryshkov
2024-08-30 10:03 ` Caleb Connolly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®