* [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF
@ 2022-05-06 12:32 YueHaibing
2022-05-06 13:01 ` Dmitry Baryshkov
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: YueHaibing @ 2022-05-06 12:32 UTC (permalink / raw)
To: airlied, daniel, tzimmermann, dmitry.baryshkov
Cc: dri-devel, linux-kernel, YueHaibing
While CONFIG_OF is n but COMPILE_TEST is y, we got this:
WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
Selected by [y]:
- DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning.
Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix this in DRM_DP_AUX_BUS dependencies
---
drivers/gpu/drm/display/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig
index 1b6e6af37546..09712b88a5b8 100644
--- a/drivers/gpu/drm/display/Kconfig
+++ b/drivers/gpu/drm/display/Kconfig
@@ -3,7 +3,7 @@
config DRM_DP_AUX_BUS
tristate
depends on DRM
- depends on OF
+ depends on OF || COMPILE_TEST
config DRM_DISPLAY_HELPER
tristate
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-06 12:32 [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF YueHaibing @ 2022-05-06 13:01 ` Dmitry Baryshkov 2022-05-06 15:52 ` Abhinav Kumar ` (2 subsequent siblings) 3 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2022-05-06 13:01 UTC (permalink / raw) To: YueHaibing, airlied, daniel, tzimmermann; +Cc: dri-devel, linux-kernel On 06/05/2022 15:32, YueHaibing wrote: > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > Selected by [y]: > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > v2: fix this in DRM_DP_AUX_BUS dependencies > --- > drivers/gpu/drm/display/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig > index 1b6e6af37546..09712b88a5b8 100644 > --- a/drivers/gpu/drm/display/Kconfig > +++ b/drivers/gpu/drm/display/Kconfig > @@ -3,7 +3,7 @@ > config DRM_DP_AUX_BUS > tristate > depends on DRM > - depends on OF > + depends on OF || COMPILE_TEST > > config DRM_DISPLAY_HELPER > tristate -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-06 12:32 [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF YueHaibing 2022-05-06 13:01 ` Dmitry Baryshkov @ 2022-05-06 15:52 ` Abhinav Kumar 2022-05-21 2:43 ` YueHaibing 2022-05-23 12:46 ` Linus Walleij 3 siblings, 0 replies; 11+ messages in thread From: Abhinav Kumar @ 2022-05-06 15:52 UTC (permalink / raw) To: YueHaibing, airlied, daniel, tzimmermann, dmitry.baryshkov Cc: linux-kernel, dri-devel On 5/6/2022 5:32 AM, YueHaibing wrote: > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > Selected by [y]: > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > v2: fix this in DRM_DP_AUX_BUS dependencies > --- > drivers/gpu/drm/display/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig > index 1b6e6af37546..09712b88a5b8 100644 > --- a/drivers/gpu/drm/display/Kconfig > +++ b/drivers/gpu/drm/display/Kconfig > @@ -3,7 +3,7 @@ > config DRM_DP_AUX_BUS > tristate > depends on DRM > - depends on OF > + depends on OF || COMPILE_TEST > > config DRM_DISPLAY_HELPER > tristate ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-06 12:32 [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF YueHaibing 2022-05-06 13:01 ` Dmitry Baryshkov 2022-05-06 15:52 ` Abhinav Kumar @ 2022-05-21 2:43 ` YueHaibing 2022-05-23 12:46 ` Linus Walleij 3 siblings, 0 replies; 11+ messages in thread From: YueHaibing @ 2022-05-21 2:43 UTC (permalink / raw) To: airlied, daniel, tzimmermann, dmitry.baryshkov; +Cc: dri-devel, linux-kernel ping... On 2022/5/6 20:32, YueHaibing wrote: > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > Selected by [y]: > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: fix this in DRM_DP_AUX_BUS dependencies > --- > drivers/gpu/drm/display/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig > index 1b6e6af37546..09712b88a5b8 100644 > --- a/drivers/gpu/drm/display/Kconfig > +++ b/drivers/gpu/drm/display/Kconfig > @@ -3,7 +3,7 @@ > config DRM_DP_AUX_BUS > tristate > depends on DRM > - depends on OF > + depends on OF || COMPILE_TEST > > config DRM_DISPLAY_HELPER > tristate > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-06 12:32 [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF YueHaibing ` (2 preceding siblings ...) 2022-05-21 2:43 ` YueHaibing @ 2022-05-23 12:46 ` Linus Walleij 2022-05-23 12:54 ` Linus Walleij 3 siblings, 1 reply; 11+ messages in thread From: Linus Walleij @ 2022-05-23 12:46 UTC (permalink / raw) To: YueHaibing Cc: airlied, daniel, tzimmermann, dmitry.baryshkov, linux-kernel, dri-devel On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@huawei.com> wrote: > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > Selected by [y]: > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch applied to the DRM tree. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-23 12:46 ` Linus Walleij @ 2022-05-23 12:54 ` Linus Walleij 2022-05-23 12:57 ` Dmitry Baryshkov ` (2 more replies) 0 siblings, 3 replies; 11+ messages in thread From: Linus Walleij @ 2022-05-23 12:54 UTC (permalink / raw) To: YueHaibing Cc: airlied, daniel, tzimmermann, dmitry.baryshkov, linux-kernel, dri-devel On Mon, May 23, 2022 at 2:46 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@huawei.com> wrote: > > > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > > Selected by [y]: > > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > > > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Patch applied to the DRM tree. Nope, failed: $ dim push-branch drm-misc-next dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): Fixes: SHA1 in not pointing at an ancestor: dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") dim: ERROR: issues in commits detected, aborting I don't know what to do with this, sorry. The other committers are maybe better with this kind of situations. I think it is designed to stop me from shooting myself in the foot. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-23 12:54 ` Linus Walleij @ 2022-05-23 12:57 ` Dmitry Baryshkov 2022-05-25 13:36 ` Dmitry Baryshkov 2022-05-26 15:02 ` Dmitry Baryshkov 2 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2022-05-23 12:57 UTC (permalink / raw) To: Linus Walleij, YueHaibing Cc: airlied, daniel, tzimmermann, linux-kernel, dri-devel On 23/05/2022 15:54, Linus Walleij wrote: > On Mon, May 23, 2022 at 2:46 PM Linus Walleij <linus.walleij@linaro.org> wrote: >> On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@huawei.com> wrote: >> >>> While CONFIG_OF is n but COMPILE_TEST is y, we got this: >>> >>> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS >>> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] >>> Selected by [y]: >>> - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) >>> >>> Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. >>> >>> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> >> Patch applied to the DRM tree. > > Nope, failed: > > $ dim push-branch drm-misc-next > dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): > Fixes: SHA1 in not pointing at an ancestor: > dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > dim: ERROR: issues in commits detected, aborting > > I don't know what to do with this, sorry. The other committers are maybe better > with this kind of situations. I think it is designed to stop me from > shooting myself > in the foot. It 'Fixes' a commit in the drm/msm tree, however a fix is not msm-specific. We can push it out through the drm/msm, but we'd need an ack from drm/core. -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-23 12:54 ` Linus Walleij 2022-05-23 12:57 ` Dmitry Baryshkov @ 2022-05-25 13:36 ` Dmitry Baryshkov 2022-05-26 20:08 ` Linus Walleij 2022-05-26 15:02 ` Dmitry Baryshkov 2 siblings, 1 reply; 11+ messages in thread From: Dmitry Baryshkov @ 2022-05-25 13:36 UTC (permalink / raw) To: Linus Walleij Cc: YueHaibing, airlied, daniel, tzimmermann, linux-kernel, dri-devel On Mon, 23 May 2022 at 15:55, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, May 23, 2022 at 2:46 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@huawei.com> wrote: > > > > > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > > > > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > > > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > > > Selected by [y]: > > > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > > > > > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > > > > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > > > Patch applied to the DRM tree. > > Nope, failed: > > $ dim push-branch drm-misc-next > dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): > Fixes: SHA1 in not pointing at an ancestor: > dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > dim: ERROR: issues in commits detected, aborting > > I don't know what to do with this, sorry. The other committers are maybe better > with this kind of situations. I think it is designed to stop me from > shooting myself > in the foot. Linus, can we get an ack from you (or anybody else from DRM core) to merge it through drm/msm tree? -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-25 13:36 ` Dmitry Baryshkov @ 2022-05-26 20:08 ` Linus Walleij 2022-05-27 9:56 ` Dmitry Baryshkov 0 siblings, 1 reply; 11+ messages in thread From: Linus Walleij @ 2022-05-26 20:08 UTC (permalink / raw) To: Dmitry Baryshkov Cc: YueHaibing, airlied, daniel, tzimmermann, linux-kernel, dri-devel On Wed, May 25, 2022 at 3:36 PM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > On Mon, 23 May 2022 at 15:55, Linus Walleij <linus.walleij@linaro.org> wrote: > > Nope, failed: > > > > $ dim push-branch drm-misc-next > > dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): > > Fixes: SHA1 in not pointing at an ancestor: > > dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > > dim: ERROR: issues in commits detected, aborting > > > > I don't know what to do with this, sorry. The other committers are maybe better > > with this kind of situations. I think it is designed to stop me from > > shooting myself > > in the foot. > > Linus, can we get an ack from you (or anybody else from DRM core) to > merge it through drm/msm tree? Acked-by: Linus Walleij <linus.walleij@linaro.org> > After a second thought, I think the patch contains wrong Fixes tag. It > should be: > > Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module") > > With that in place would we be able to merge it through drm-misc? Does > it needs to be resubmitted? But it doesn't apply to drm-misc... that's my problem :/ Yours, Linus Walleij ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-26 20:08 ` Linus Walleij @ 2022-05-27 9:56 ` Dmitry Baryshkov 0 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2022-05-27 9:56 UTC (permalink / raw) To: Linus Walleij Cc: YueHaibing, airlied, daniel, tzimmermann, linux-kernel, dri-devel On 26/05/2022 23:08, Linus Walleij wrote: > On Wed, May 25, 2022 at 3:36 PM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> On Mon, 23 May 2022 at 15:55, Linus Walleij <linus.walleij@linaro.org> wrote: > >>> Nope, failed: >>> >>> $ dim push-branch drm-misc-next >>> dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): >>> Fixes: SHA1 in not pointing at an ancestor: >>> dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") >>> dim: ERROR: issues in commits detected, aborting >>> >>> I don't know what to do with this, sorry. The other committers are maybe better >>> with this kind of situations. I think it is designed to stop me from >>> shooting myself >>> in the foot. >> >> Linus, can we get an ack from you (or anybody else from DRM core) to >> merge it through drm/msm tree? > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > >> After a second thought, I think the patch contains wrong Fixes tag. It >> should be: >> >> Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module") >> >> With that in place would we be able to merge it through drm-misc? Does >> it needs to be resubmitted? > > But it doesn't apply to drm-misc... that's my problem :/ I think it didn't apply because of the Fixes from msm-next. If we change that to the mentioned commit (1e0f66420b13), then you should be able to push it. -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF 2022-05-23 12:54 ` Linus Walleij 2022-05-23 12:57 ` Dmitry Baryshkov 2022-05-25 13:36 ` Dmitry Baryshkov @ 2022-05-26 15:02 ` Dmitry Baryshkov 2 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2022-05-26 15:02 UTC (permalink / raw) To: Linus Walleij, YueHaibing Cc: airlied, daniel, tzimmermann, linux-kernel, dri-devel Hi Linus, Yue, On 23/05/2022 15:54, Linus Walleij wrote: > On Mon, May 23, 2022 at 2:46 PM Linus Walleij <linus.walleij@linaro.org> wrote: >> On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@huawei.com> wrote: >> >>> While CONFIG_OF is n but COMPILE_TEST is y, we got this: >>> >>> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS >>> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] >>> Selected by [y]: >>> - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) >>> >>> Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. >>> >>> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> >> Patch applied to the DRM tree. > > Nope, failed: > > $ dim push-branch drm-misc-next > dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): > Fixes: SHA1 in not pointing at an ancestor: > dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > dim: ERROR: issues in commits detected, aborting After a second thought, I think the patch contains wrong Fixes tag. It should be: Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module") With that in place would we be able to merge it through drm-misc? Does it needs to be resubmitted? > > I don't know what to do with this, sorry. The other committers are maybe better > with this kind of situations. I think it is designed to stop me from > shooting myself > in the foot. > > Yours, > Linus Walleij -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-05-27 9:57 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-05-06 12:32 [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF YueHaibing 2022-05-06 13:01 ` Dmitry Baryshkov 2022-05-06 15:52 ` Abhinav Kumar 2022-05-21 2:43 ` YueHaibing 2022-05-23 12:46 ` Linus Walleij 2022-05-23 12:54 ` Linus Walleij 2022-05-23 12:57 ` Dmitry Baryshkov 2022-05-25 13:36 ` Dmitry Baryshkov 2022-05-26 20:08 ` Linus Walleij 2022-05-27 9:56 ` Dmitry Baryshkov 2022-05-26 15:02 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®