From: "wanghai (M)" <wanghai38@huawei.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
Mao Wenan <maowenan@huawei.com>, <jrosen@cisco.com>,
Arnd Bergmann <arnd@arndb.de>,
Colin King <colin.king@canonical.com>,
Eric Dumazet <edumazet@google.com>,
"Network Development" <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV
Date: Sat, 5 Sep 2020 11:00:27 +0800 [thread overview]
Message-ID: <df2a5c42-3b06-1801-9bf1-8f304d839620@huawei.com> (raw)
In-Reply-To: <CA+FuTSfMO4YPGp88HYRPWwRUCg79SVyYicOowCH9oJkKPtmdLA@mail.gmail.com>
在 2020/9/4 21:26, Willem de Bruijn 写道:
> On Fri, Sep 4, 2020 at 3:09 PM Wang Hai <wanghai38@huawei.com> wrote:
>> BPDU_TYPE_TCN is never used after it was introduced.
>> So better to remove it.
> This comment does not cover the patch contents. Otherwise the patch
> looks good to me.
Thanks for your review, I will revise this comment.
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
>> ---
>> net/packet/af_packet.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
>> index da8254e680f9..c430672c6a67 100644
>> --- a/net/packet/af_packet.c
>> +++ b/net/packet/af_packet.c
>> @@ -177,7 +177,6 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
>> #define BLOCK_LEN(x) ((x)->hdr.bh1.blk_len)
>> #define BLOCK_SNUM(x) ((x)->hdr.bh1.seq_num)
>> #define BLOCK_O2PRIV(x) ((x)->offset_to_priv)
>> -#define BLOCK_PRIV(x) ((void *)((char *)(x) + BLOCK_O2PRIV(x)))
>>
>> struct packet_sock;
>> static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev,
>> --
>> 2.17.1
>>
> .
>
prev parent reply other threads:[~2020-09-05 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 13:06 Wang Hai
2020-09-04 13:26 ` Willem de Bruijn
2020-09-05 3:00 ` wanghai (M) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df2a5c42-3b06-1801-9bf1-8f304d839620@huawei.com \
--to=wanghai38@huawei.com \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.ogness@linutronix.de \
--cc=jrosen@cisco.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®