mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Santos <Jonathan.Santos@analog.com>
To: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Jonathan Santos <Jonathan.Santos@analog.com>, <lars@metafoo.de>,
	<Michael.Hennerich@analog.com>, <marcelo.schmitt@analog.com>,
	<jic23@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <jonath4nns@gmail.com>,
	<marcelo.schmitt1@gmail.com>
Subject: [PATCH v2 09/16] iio: adc: ad7768-1: remove unnecessary locking
Date: Mon, 27 Jan 2025 12:13:08 -0300	[thread overview]
Message-ID: <df331cd681feb756d06df4173f67f75ec655bfb2.1737985435.git.Jonathan.Santos@analog.com> (raw)
In-Reply-To: <cover.1737985435.git.Jonathan.Santos@analog.com>

The current locking is only preventing a triggered buffer Transfer and a
debugfs register access from happening at the same time. If a register
access happens during a buffered read, the action is doomed to fail anyway,
since we need to write a magic value to exit continuous read mode.

Remove locking from the trigger handler and use
iio_device_claim_direct_mode() instead in the register access function.

Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
---
v2 Changes:
* New patch in v2. It replaces the guard(mutex) patch. 
---
 drivers/iio/adc/ad7768-1.c | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 17a49bf74637..5e2093be9b92 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -271,16 +271,16 @@ static int ad7768_reg_access(struct iio_dev *indio_dev,
 	struct ad7768_state *st = iio_priv(indio_dev);
 	int ret;
 
-	mutex_lock(&st->lock);
-	if (readval) {
+	ret = iio_device_claim_direct_mode(indio_dev);
+	if (ret)
+		return ret;
+
+	if (readval)
 		ret = regmap_read(st->regmap, reg, readval);
-		if (ret)
-			goto err_unlock;
-	} else {
+	else
 		ret = regmap_write(st->regmap, reg, writeval);
-	}
-err_unlock:
-	mutex_unlock(&st->lock);
+
+	iio_device_release_direct_mode(indio_dev);
 
 	return ret;
 }
@@ -495,18 +495,15 @@ static irqreturn_t ad7768_trigger_handler(int irq, void *p)
 	struct ad7768_state *st = iio_priv(indio_dev);
 	int ret;
 
-	mutex_lock(&st->lock);
-
 	ret = spi_read(st->spi, &st->data.scan.chan, 3);
 	if (ret < 0)
-		goto err_unlock;
+		goto out;
 
 	iio_push_to_buffers_with_timestamp(indio_dev, &st->data.scan,
 					   iio_get_time_ns(indio_dev));
 
-err_unlock:
+out:
 	iio_trigger_notify_done(indio_dev->trig);
-	mutex_unlock(&st->lock);
 
 	return IRQ_HANDLED;
 }
-- 
2.34.1


  parent reply	other threads:[~2025-01-27 15:13 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 15:10 [PATCH v2 00/16] Add features, improvements, and fixes Jonathan Santos
2025-01-27 15:11 ` [PATCH v2 01/16] iio: adc: ad7768-1: Fix conversion result sign Jonathan Santos
2025-02-01 15:27   ` Jonathan Cameron
2025-02-01 15:36   ` Jonathan Cameron
2025-01-27 15:11 ` [PATCH v2 02/16] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-01-27 16:30   ` Rob Herring (Arm)
2025-01-27 16:55   ` Rob Herring
2025-01-28  1:28   ` David Lechner
2025-01-28 15:04     ` Jonathan Santos
2025-01-28 15:56       ` David Lechner
2025-01-30 16:16         ` Jonathan Cameron
2025-01-27 15:11 ` [PATCH v2 03/16] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-01-27 16:30   ` Rob Herring (Arm)
2025-01-27 16:56   ` Rob Herring (Arm)
2025-01-27 15:12 ` [PATCH v2 04/16] dt-bindings: iio: adc: ad7768-1: add VMC output property Jonathan Santos
2025-01-27 16:30   ` Rob Herring (Arm)
2025-01-28  1:28   ` David Lechner
2025-01-30 16:21     ` Jonathan Cameron
2025-01-27 15:12 ` [PATCH v2 05/16] Documentation: ABI: add wideband filter type to sysfs-bus-iio Jonathan Santos
2025-01-28  1:32   ` David Lechner
2025-01-30 16:29     ` Jonathan Cameron
2025-01-27 15:12 ` [PATCH v2 06/16] iio: adc: ad7768-1: set MOSI idle state to prevent accidental reset Jonathan Santos
2025-02-01 15:31   ` Jonathan Cameron
2025-02-03 11:34     ` Jonathan Santos
2025-01-27 15:12 ` [PATCH v2 07/16] iio: adc: ad7768-1: convert driver to use regmap Jonathan Santos
2025-01-28  1:29   ` David Lechner
2025-01-28 13:25     ` Nuno Sá
2025-01-28 14:46       ` Jonathan Santos
2025-01-28 15:09         ` Nuno Sá
2025-01-30 16:32           ` Jonathan Cameron
2025-02-03 11:44             ` Jonathan Santos
2025-01-27 15:12 ` [PATCH v2 08/16] iio: adc: ad7768-1: Add reset gpio Jonathan Santos
2025-01-27 22:43   ` David Lechner
2025-02-03 13:46   ` Marcelo Schmitt
2025-01-27 15:13 ` Jonathan Santos [this message]
2025-01-27 22:46   ` [PATCH v2 09/16] iio: adc: ad7768-1: remove unnecessary locking David Lechner
2025-01-27 15:13 ` [PATCH v2 10/16] iio: adc: ad7768-1: Move buffer allocation to a separate function Jonathan Santos
2025-02-01 15:35   ` Jonathan Cameron
2025-02-03 12:03     ` Jonathan Santos
2025-01-27 15:13 ` [PATCH v2 11/16] iio: adc: ad7768-1: Add VCM output support Jonathan Santos
2025-01-27 23:07   ` David Lechner
2025-01-27 15:13 ` [PATCH v2 12/16] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-01-27 23:34   ` David Lechner
2025-02-03 13:08     ` Jonathan Santos
2025-02-01 15:50   ` Jonathan Cameron
2025-01-27 15:13 ` [PATCH v2 13/16] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-01-27 23:47   ` David Lechner
2025-01-27 15:14 ` [PATCH v2 14/16] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-01-28  0:08   ` David Lechner
2025-02-03 15:28   ` Marcelo Schmitt
2025-01-27 15:14 ` [PATCH v2 15/16] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-01-28  1:24   ` David Lechner
2025-02-03 14:58     ` Jonathan Santos
2025-01-30 16:39   ` Jonathan Cameron
2025-01-27 15:14 ` [PATCH v2 16/16] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-01-28  1:27   ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df331cd681feb756d06df4173f67f75ec655bfb2.1737985435.git.Jonathan.Santos@analog.com \
    --to=jonathan.santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=jonath4nns@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®