From: "Nemanov, Michael" <michael.nemanov@ti.com>
To: David Lin <yu-hao.lin@nxp.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"briannorris@chromium.org" <briannorris@chromium.org>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"francesco@dolcini.it" <francesco@dolcini.it>,
Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: [PATCH 26/43] wifi: nxpwifi: add sdio.c
Date: Thu, 27 Jun 2024 09:26:51 +0300 [thread overview]
Message-ID: <df34e044-8c51-4ced-8381-cbf424711e2f@ti.com> (raw)
In-Reply-To: <PA4PR04MB963897BF79B6F05700263A7CD1D72@PA4PR04MB9638.eurprd04.prod.outlook.com>
On 6/27/2024 6:37 AM, David Lin wrote:
>>
>> On 6/21/2024 10:51 AM, David Lin wrote:
>> ...
>>> +
>>> +/* This function unregisters the SDIO device.
>>> + *
>>> + * The SDIO IRQ is released, the function is disabled and driver
>>> + * data is set to null.
>>> + */
>>> +static void
>>> +nxpwifi_unregister_dev(struct nxpwifi_adapter *adapter) {
>>> + struct sdio_mmc_card *card = adapter->card;
>>> +
>>> + if (adapter->card) {
>>> + card->adapter = NULL;
>>> + sdio_claim_host(card->func);
>>> + sdio_disable_func(card->func);
>>> + sdio_release_host(card->func);
>>> + }
>>> +}
>>
>> Missing call to sdio_release_irq() ?
>>
>> Michael.
>
> sdio_release_irq() is called by nxpwifi_sdio_disable_host_int().
>
> David
Right, I see you calling it from nxpwifi_uninit_sw(). Maybe just align
the comment then.
Michael.
next prev parent reply other threads:[~2024-06-27 6:27 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 7:51 [PATCH 00/43] wifi: nxpwifi: create nxpwifi to support iw61x David Lin
2024-06-21 7:51 ` [PATCH 01/43] wifi: nxpwifi: add 11ac.c David Lin
2024-06-28 8:22 ` Abel Vesa
2024-07-01 0:46 ` [EXT] " David Lin
2024-06-21 7:51 ` [PATCH 02/43] wifi: nxpwifi: add 11ac.h David Lin
2024-06-21 7:51 ` [PATCH 03/43] wifi: nxpwifi: add 11h.c David Lin
2024-06-21 7:51 ` [PATCH 04/43] wifi: nxpwifi: add 11n.c David Lin
2024-06-21 7:51 ` [PATCH 05/43] wifi: nxpwifi: add 11n.h David Lin
2024-06-21 7:51 ` [PATCH 06/43] wifi: nxpwifi: add 11n_aggr.c David Lin
2024-06-21 7:51 ` [PATCH 07/43] wifi: nxpwifi: add 11n_aggr.h David Lin
2024-06-21 7:51 ` [PATCH 08/43] wifi: nxpwifi: add 11n_rxreorder.c David Lin
2024-06-21 7:51 ` [PATCH 09/43] wifi: nxpwifi: add 11n_rxreorder.h David Lin
2024-06-21 7:51 ` [PATCH 10/43] wifi: nxpwifi: add cfg80211.c David Lin
2024-06-21 7:51 ` [PATCH 11/43] wifi: nxpwifi: add cfg80211.h David Lin
2024-06-21 7:51 ` [PATCH 12/43] wifi: nxpwifi: add cfp.c David Lin
2024-06-21 7:51 ` [PATCH 13/43] wifi: nxpwifi: add cmdevt.c David Lin
2024-06-21 7:51 ` [PATCH 14/43] wifi: nxpwifi: add cmdevt.h David Lin
2024-06-21 7:51 ` [PATCH 15/43] wifi: nxpwifi: add debugfs.c David Lin
2024-06-21 7:51 ` [PATCH 16/43] wifi: nxpwifi: add decl.h David Lin
2024-06-21 7:51 ` [PATCH 17/43] wifi: nxpwifi: add ethtool.c David Lin
2024-06-21 7:51 ` [PATCH 18/43] wifi: nxpwifi: add fw.h David Lin
2024-06-21 7:51 ` [PATCH 19/43] wifi: nxpwifi: add ie.c David Lin
2024-06-21 7:51 ` [PATCH 20/43] wifi: nxpwifi: add init.c David Lin
2024-06-21 7:51 ` [PATCH 21/43] wifi: nxpwifi: add ioctl.h David Lin
2024-06-21 7:51 ` [PATCH 22/43] wifi: nxpwifi: add join.c David Lin
2024-06-21 7:51 ` [PATCH 23/43] wifi: nxpwifi: add main.c David Lin
2024-06-21 7:51 ` [PATCH 24/43] wifi: nxpwifi: add main.h David Lin
2024-06-21 7:51 ` [PATCH 25/43] wifi: nxpwifi: add scan.c David Lin
2024-06-21 7:51 ` [PATCH 26/43] wifi: nxpwifi: add sdio.c David Lin
2024-06-26 11:40 ` [EXTERNAL] " Nemanov, Michael
2024-06-27 3:37 ` [EXT] " David Lin
2024-06-27 6:26 ` Nemanov, Michael [this message]
2024-06-27 6:33 ` [EXT] " David Lin
2024-06-21 7:51 ` [PATCH 27/43] wifi: nxpwifi: add sdio.h David Lin
2024-06-21 7:51 ` [PATCH 28/43] wifi: nxpwifi: add sta_cmd.c David Lin
2024-06-21 7:51 ` [PATCH 29/43] wifi: nxpwifi: add sta_event.c David Lin
2024-06-21 7:51 ` [PATCH 30/43] wifi: nxpwifi: add sta_ioctl.c David Lin
2024-06-21 7:51 ` [PATCH 31/43] wifi: nxpwifi: add sta_rx.c David Lin
2024-06-21 7:51 ` [PATCH 32/43] wifi: nxpwifi: add sta_tx.c David Lin
2024-06-21 7:51 ` [PATCH 33/43] wifi: nxpwifi: add txrx.c David Lin
2024-06-21 7:51 ` [PATCH 34/43] wifi: nxpwifi: add uap_cmd.c David Lin
2024-06-21 7:52 ` [PATCH 35/43] wifi: nxpwifi: add uap_event.c David Lin
2024-06-21 7:52 ` [PATCH 36/43] wifi: nxpwifi: add uap_txrx.c David Lin
2024-06-21 7:52 ` [PATCH 37/43] wifi: nxpwifi: add util.c David Lin
2024-06-21 7:52 ` [PATCH 38/43] wifi: nxpwifi: add util.h David Lin
2024-06-21 7:52 ` [PATCH 39/43] wifi: nxpwifi: add wmm.c David Lin
2024-06-21 7:52 ` [PATCH 40/43] wifi: nxpwifi: add wmm.h David Lin
2024-06-21 7:52 ` [PATCH 41/43] wifi: nxpwifi: add nxp sdio vendor id and iw61x device id David Lin
2024-06-21 7:52 ` [PATCH 42/43] wifi: nxpwifi: add Makefile and Kconfig files for nxpwifi compilation David Lin
2024-06-26 0:19 ` kernel test robot
2024-06-26 0:24 ` kernel test robot
2024-06-28 4:46 ` kernel test robot
2024-06-21 7:52 ` [PATCH 43/43] wifi: nxpwifi: add nxpwifi related information to MAINTAINERS David Lin
2024-06-21 17:53 ` [PATCH 00/43] wifi: nxpwifi: create nxpwifi to support iw61x Brian Norris
2024-06-21 18:20 ` Johannes Berg
2024-07-01 1:08 ` [EXT] " David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df34e044-8c51-4ced-8381-cbf424711e2f@ti.com \
--to=michael.nemanov@ti.com \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®