mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yum Rayan" <yum.rayan@gmail.com>
To: amah@highpoint-tech.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, akpm@osdl.org
Subject: Re:[PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver
Date: Tue, 9 May 2006 16:29:47 -0700	[thread overview]
Message-ID: <df35dfeb0605091629y6f2390f3lad8f99c7aad62c4f@mail.gmail.com> (raw)
In-Reply-To: <464B3C0C5BFD894FADEFDD94B6D734E488181E@taus-ies1.dom1.taus.us.thales>

> +static ssize_t hptiop_show_devicelist(struct class_device *class_dev,
> char
> *buf)

There is a one value per sysfs attribute rule. Seems like you are
returning quite some info here.

> + /* map buffer to kernel. */
> + if (ioctl_k.inbuf_size) {
> +  ioctl_k.inbuf = kmalloc(ioctl_k.inbuf_size, GFP_KERNEL);
> +  if (!ioctl_k.inbuf) {
> +   dprintk("scsi%d: fail to alloc inbuf\n",
> +     hba->host->host_no);
> +   err = -ENOMEM;
> +   goto err_exit;
> +  }
> +
> +  if (copy_from_user(ioctl_k.inbuf,
> +    ioctl_u->inbuf, ioctl_k.inbuf_size)) {
> +   goto err_exit;
> +  }

You are essentially wrapping ioctl with sysfs and passing user space
buffers....

> + .proc_name                  = driver_name,

I believe this is going away.

> + printk(KERN_INFO "%s %s\n", driver_name_long, driver_ver);
> +
> + return pci_module_init(&hptiop_pci_driver);
> +}
> +

pci_register_driver? pci.h indicates that pci_module_init is being obsoleted...

           reply	other threads:[~2006-05-09 23:29 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <464B3C0C5BFD894FADEFDD94B6D734E488181E@taus-ies1.dom1.taus.us.thales>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df35dfeb0605091629y6f2390f3lad8f99c7aad62c4f@mail.gmail.com \
    --to=yum.rayan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=amah@highpoint-tech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®