* Re:[PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver
[not found] <464B3C0C5BFD894FADEFDD94B6D734E488181E@taus-ies1.dom1.taus.us.thales>
@ 2006-05-09 23:29 ` Yum Rayan
0 siblings, 0 replies; only message in thread
From: Yum Rayan @ 2006-05-09 23:29 UTC (permalink / raw)
To: amah, linux-kernel, linux-scsi, akpm
> +static ssize_t hptiop_show_devicelist(struct class_device *class_dev,
> char
> *buf)
There is a one value per sysfs attribute rule. Seems like you are
returning quite some info here.
> + /* map buffer to kernel. */
> + if (ioctl_k.inbuf_size) {
> + ioctl_k.inbuf = kmalloc(ioctl_k.inbuf_size, GFP_KERNEL);
> + if (!ioctl_k.inbuf) {
> + dprintk("scsi%d: fail to alloc inbuf\n",
> + hba->host->host_no);
> + err = -ENOMEM;
> + goto err_exit;
> + }
> +
> + if (copy_from_user(ioctl_k.inbuf,
> + ioctl_u->inbuf, ioctl_k.inbuf_size)) {
> + goto err_exit;
> + }
You are essentially wrapping ioctl with sysfs and passing user space
buffers....
> + .proc_name = driver_name,
I believe this is going away.
> + printk(KERN_INFO "%s %s\n", driver_name_long, driver_ver);
> +
> + return pci_module_init(&hptiop_pci_driver);
> +}
> +
pci_register_driver? pci.h indicates that pci_module_init is being obsoleted...
^ permalink raw reply [flat|nested] only message in thread