From: Lukasz Luba <lukasz.luba@arm.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Yaxiong Tian <tianyaxiong@kylinos.cn>,
Yaxiong Tian <iambestgod@qq.com>
Subject: Re: [PATCH v3] PM: EM: Fix potential division-by-zero error in em_compute_costs()
Date: Wed, 16 Apr 2025 16:26:03 +0100 [thread overview]
Message-ID: <df494648-b0c1-402b-8644-b50f20011c5f@arm.com> (raw)
In-Reply-To: <CAJZ5v0iq4bw3WAk1yQRP=B3zk-rRYwibKNRjSfu=PGqTt6RNYw@mail.gmail.com>
On 4/16/25 12:58, Rafael J. Wysocki wrote:
> On Wed, Apr 16, 2025 at 4:57 AM Yaxiong Tian <iambestgod@qq.com> wrote:
>>
>> 在 2025/4/16 01:17, Rafael J. Wysocki 写道:
>>> On Mon, Apr 14, 2025 at 11:09 AM Yaxiong Tian <iambestgod@qq.com> wrote:
>>>>
>>>> From: Yaxiong Tian <tianyaxiong@kylinos.cn>
>>>>
>>>> When the device is of a non-CPU type, table[i].performance won't be
>>>> initialized in the previous em_init_performance(), resulting in division
>>>> by zero when calculating costs in em_compute_costs().
>>>>
>>>> Since the 'cost' algorithm is only used for EAS energy efficiency
>>>> calculations and is currently not utilized by other device drivers, we
>>>> should add the _is_cpu_device(dev) check to prevent this division-by-zero
>>>> issue.
>>>>
>>>> Fixes: <1b600da51073> ("PM: EM: Optimize em_cpu_energy() and remove division")
>>>
>>> Please look at the Fixes: tags in the kernel git history. They don't
>>> look like the one above.
>>>
>> Yes, there's an extra '<>' here.
>>
>>>> Signed-off-by: Yaxiong Tian <tianyaxiong@kylinos.cn>
>>>> ---
>>>> kernel/power/energy_model.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
>>>> index d9b7e2b38c7a..fc972cc1fc12 100644
>>>> --- a/kernel/power/energy_model.c
>>>> +++ b/kernel/power/energy_model.c
>>>> @@ -235,7 +235,7 @@ static int em_compute_costs(struct device *dev, struct em_perf_state *table,
>>>>
>>>> /* Compute the cost of each performance state. */
>>>> for (i = nr_states - 1; i >= 0; i--) {
>>>> - unsigned long power_res, cost;
>>>> + unsigned long power_res, cost = 0;
>>>>
>>>> if ((flags & EM_PERF_DOMAIN_ARTIFICIAL) && cb->get_cost) {
>>>> ret = cb->get_cost(dev, table[i].frequency, &cost);
>>>> @@ -244,7 +244,7 @@ static int em_compute_costs(struct device *dev, struct em_perf_state *table,
>>>> cost, ret);
>>>> return -EINVAL;
>>>> }
>>>> - } else {
>>>> + } else if (_is_cpu_device(dev)) {
>>>
>>> Can't you just check this upfront at the beginning of the function and
>>> make it bail out if dev is not a CPU device?
>>>
>> Sure, But the current implementation applies em_compute_costs() to both
>> non-CPU devices and CPU devices.
>
> Maybe it shouldn't do that for non-CPU ones?
It shouldn't call this cost computation for non-CPU devices.
Let me check that.
next prev parent reply other threads:[~2025-04-16 15:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 1:28 [PATCH v2] " Yaxiong Tian
2025-04-12 1:55 ` kernel test robot
2025-04-14 8:08 ` Lukasz Luba
2025-04-14 9:08 ` Yaxiong Tian
2025-04-17 7:20 ` Geert Uytterhoeven
2025-04-17 7:41 ` Yaxiong Tian
2025-04-15 1:12 ` Yaxiong Tian
2025-04-15 1:58 ` Yaxiong Tian
2025-04-15 17:19 ` Rafael J. Wysocki
2025-04-14 9:04 ` [PATCH v3] " Yaxiong Tian
2025-04-15 8:50 ` Lukasz Luba
2025-04-15 17:17 ` Rafael J. Wysocki
2025-04-16 2:56 ` Yaxiong Tian
2025-04-16 11:58 ` Rafael J. Wysocki
2025-04-16 15:26 ` Lukasz Luba [this message]
2025-04-17 0:56 ` Yaxiong Tian
2025-04-17 1:07 ` [PATCH v4] " Yaxiong Tian
2025-04-17 5:57 ` Lukasz Luba
2025-04-17 7:43 ` Yaxiong Tian
2025-04-17 13:27 ` Lukasz Luba
2025-04-18 1:26 ` Yaxiong Tian
2025-04-28 1:45 ` Yaxiong Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df494648-b0c1-402b-8644-b50f20011c5f@arm.com \
--to=lukasz.luba@arm.com \
--cc=iambestgod@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tianyaxiong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®