mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Cryolitia PukNgae <cryolitia@uniontech.com>,
	luoqing <l1138897701@163.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	luoqing@kylinos.cn
Subject: Re: [PATCH] hwmon: (gpd-fan) Fix the compilation error
Date: Wed, 12 Nov 2025 12:03:45 -0800	[thread overview]
Message-ID: <dfb3f5df-4ca7-4965-bfe9-07fb473f0506@roeck-us.net> (raw)
In-Reply-To: <D1B4B203872C7799+d5630d66-0557-49bc-baf5-2abbe50cc625@uniontech.com>

On 11/11/25 19:09, Cryolitia PukNgae wrote:
> On 12/11/2025 09.57, luoqing wrote:
>> From: luoqing <luoqing@kylinos.cn>
>>
>> drivers/hwmon/gpd-fan.c: in the function 'gpd_ecram_read' :
>> drivers/hwmon/gpd-fan.c:231:9: Error: implicit declaration function 'outb' [-Werror= implrecental-function-declaration]
>> 231 |         outb(0x2E, addr_port);
>> ^~~~
>> drivers/hwmon/gpd-fan.c:244:16: Error: implicit declaration function 'inb' [-Werror= implrecental-function-declaration]
>> 244 |         *val = inb(data_port);
>> ^~~
>> cc1: All warnings were regarded as errors
>>
>> Signed-off-by: luoqing <luoqing@kylinos.cn>
>> ---
>>   drivers/hwmon/gpd-fan.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
>> index 321794807e8d..57d4ee683f0d 100644
>> --- a/drivers/hwmon/gpd-fan.c
>> +++ b/drivers/hwmon/gpd-fan.c
>> @@ -19,6 +19,7 @@
>>   #include <linux/kernel.h>
>>   #include <linux/module.h>
>>   #include <linux/platform_device.h>
>> +#include <linux/io.h>
>>   
>>   #define DRIVER_NAME "gpdfan"
>>   #define GPD_PWM_CTR_OFFSET 0x1841
> 
> Has it already been fixed in it[1] ?
> 
> 1. https://lore.kernel.org/all/20251024202042.752160-1-krishnagopi487@gmail.com/#t
> 
Yes, I'll just need to send the pull request.

Guenter


      reply	other threads:[~2025-11-12 20:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12  1:57 luoqing
2025-11-12  3:09 ` Cryolitia PukNgae
2025-11-12 20:03   ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfb3f5df-4ca7-4965-bfe9-07fb473f0506@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=cryolitia@uniontech.com \
    --cc=l1138897701@163.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luoqing@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®