* [PATCH] hwmon: (gpd-fan) Fix the compilation error
@ 2025-11-12 1:57 luoqing
2025-11-12 3:09 ` Cryolitia PukNgae
0 siblings, 1 reply; 3+ messages in thread
From: luoqing @ 2025-11-12 1:57 UTC (permalink / raw)
To: cryolitia; +Cc: linux, linux-hwmon, linux-kernel, luoqing
From: luoqing <luoqing@kylinos.cn>
drivers/hwmon/gpd-fan.c: in the function 'gpd_ecram_read' :
drivers/hwmon/gpd-fan.c:231:9: Error: implicit declaration function 'outb' [-Werror= implrecental-function-declaration]
231 | outb(0x2E, addr_port);
^~~~
drivers/hwmon/gpd-fan.c:244:16: Error: implicit declaration function 'inb' [-Werror= implrecental-function-declaration]
244 | *val = inb(data_port);
^~~
cc1: All warnings were regarded as errors
Signed-off-by: luoqing <luoqing@kylinos.cn>
---
drivers/hwmon/gpd-fan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
index 321794807e8d..57d4ee683f0d 100644
--- a/drivers/hwmon/gpd-fan.c
+++ b/drivers/hwmon/gpd-fan.c
@@ -19,6 +19,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/io.h>
#define DRIVER_NAME "gpdfan"
#define GPD_PWM_CTR_OFFSET 0x1841
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (gpd-fan) Fix the compilation error
2025-11-12 1:57 [PATCH] hwmon: (gpd-fan) Fix the compilation error luoqing
@ 2025-11-12 3:09 ` Cryolitia PukNgae
2025-11-12 20:03 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Cryolitia PukNgae @ 2025-11-12 3:09 UTC (permalink / raw)
To: luoqing; +Cc: linux, linux-hwmon, linux-kernel, luoqing
On 12/11/2025 09.57, luoqing wrote:
> From: luoqing <luoqing@kylinos.cn>
>
> drivers/hwmon/gpd-fan.c: in the function 'gpd_ecram_read' :
> drivers/hwmon/gpd-fan.c:231:9: Error: implicit declaration function 'outb' [-Werror= implrecental-function-declaration]
> 231 | outb(0x2E, addr_port);
> ^~~~
> drivers/hwmon/gpd-fan.c:244:16: Error: implicit declaration function 'inb' [-Werror= implrecental-function-declaration]
> 244 | *val = inb(data_port);
> ^~~
> cc1: All warnings were regarded as errors
>
> Signed-off-by: luoqing <luoqing@kylinos.cn>
> ---
> drivers/hwmon/gpd-fan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
> index 321794807e8d..57d4ee683f0d 100644
> --- a/drivers/hwmon/gpd-fan.c
> +++ b/drivers/hwmon/gpd-fan.c
> @@ -19,6 +19,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> +#include <linux/io.h>
>
> #define DRIVER_NAME "gpdfan"
> #define GPD_PWM_CTR_OFFSET 0x1841
Has it already been fixed in it[1] ?
1. https://lore.kernel.org/all/20251024202042.752160-1-krishnagopi487@gmail.com/#t
Best regards,
Cryolitia PukNgae
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (gpd-fan) Fix the compilation error
2025-11-12 3:09 ` Cryolitia PukNgae
@ 2025-11-12 20:03 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2025-11-12 20:03 UTC (permalink / raw)
To: Cryolitia PukNgae, luoqing; +Cc: linux-hwmon, linux-kernel, luoqing
On 11/11/25 19:09, Cryolitia PukNgae wrote:
> On 12/11/2025 09.57, luoqing wrote:
>> From: luoqing <luoqing@kylinos.cn>
>>
>> drivers/hwmon/gpd-fan.c: in the function 'gpd_ecram_read' :
>> drivers/hwmon/gpd-fan.c:231:9: Error: implicit declaration function 'outb' [-Werror= implrecental-function-declaration]
>> 231 | outb(0x2E, addr_port);
>> ^~~~
>> drivers/hwmon/gpd-fan.c:244:16: Error: implicit declaration function 'inb' [-Werror= implrecental-function-declaration]
>> 244 | *val = inb(data_port);
>> ^~~
>> cc1: All warnings were regarded as errors
>>
>> Signed-off-by: luoqing <luoqing@kylinos.cn>
>> ---
>> drivers/hwmon/gpd-fan.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
>> index 321794807e8d..57d4ee683f0d 100644
>> --- a/drivers/hwmon/gpd-fan.c
>> +++ b/drivers/hwmon/gpd-fan.c
>> @@ -19,6 +19,7 @@
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> #include <linux/platform_device.h>
>> +#include <linux/io.h>
>>
>> #define DRIVER_NAME "gpdfan"
>> #define GPD_PWM_CTR_OFFSET 0x1841
>
> Has it already been fixed in it[1] ?
>
> 1. https://lore.kernel.org/all/20251024202042.752160-1-krishnagopi487@gmail.com/#t
>
Yes, I'll just need to send the pull request.
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-12 20:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-12 1:57 [PATCH] hwmon: (gpd-fan) Fix the compilation error luoqing
2025-11-12 3:09 ` Cryolitia PukNgae
2025-11-12 20:03 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®