From: Ray Jui <ray.jui@broadcom.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>,
Lori Hikichi <lori.hikichi@broadcom.com>,
Icarus Chau <icarus.chau@broadcom.com>,
Shivaraj Shetty <sshetty1@broadcom.com>
Subject: Re: [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability
Date: Tue, 24 Sep 2019 15:23:57 -0700 [thread overview]
Message-ID: <e00520d8-5367-83a5-9c17-d2d8b0c983c3@broadcom.com> (raw)
In-Reply-To: <20190924185757.GA1538@kunai>
On 9/24/19 11:57 AM, Wolfram Sang wrote:
>
>> In my opinion, it's probably better to continue to support master_xfer in
>> our driver (with obvious limitations), in order to allow i2ctransfer (or any
>> apps that use I2C RDWR) to continue to work.
>>
>> What do you think?
>
> Yes, don't break it for users. We should have paid more attention to it
> in the beginning. But, while not ideal, it is not such a big deal to
> keep it like this.
>
> Thanks for your investigations!
>
Thanks, Wolfram.
Let's please continue with the review process on the current patch then?
Note the patch was already internally reviewed by me.
Please help to review it and let us know if there's any change that
needs to be made?
Regards,
Ray
prev parent reply other threads:[~2019-09-24 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 4:09 Rayagonda Kokatanur
2019-08-12 17:33 ` Ray Jui
2019-08-29 20:41 ` Wolfram Sang
2019-08-30 12:56 ` Wolfram Sang
2019-08-30 18:35 ` Ray Jui
2019-08-31 9:49 ` Wolfram Sang
2019-09-03 23:11 ` Ray Jui
2019-09-04 21:37 ` Wolfram Sang
2019-09-24 17:23 ` Ray Jui
2019-09-24 18:57 ` Wolfram Sang
2019-09-24 22:23 ` Ray Jui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e00520d8-5367-83a5-9c17-d2d8b0c983c3@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=icarus.chau@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lori.hikichi@broadcom.com \
--cc=mark.rutland@arm.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sshetty1@broadcom.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®