* [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked()
@ 2024-07-18 18:30 Dan Carpenter
2024-07-18 18:37 ` Frank Li
2024-07-23 23:51 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-07-18 18:30 UTC (permalink / raw)
To: Frank Li
Cc: Miquel Raynal, Conor Culhane, Alexandre Belloni, linux-i3c,
linux-kernel, kernel-janitors
This code has a typo so it returns positive EIO instead of negative -EIO. Fix
it!
Fixes: a7809cb368b9 ("i3c: master: svc: Improve DAA STOP handle code logic")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/i3c/master/svc-i3c-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index e80c002991f7..0a68fd1b81d4 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -874,7 +874,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
* address this time.
*/
if (prov_id[dev_nb] == nacking_prov_id) {
- ret = EIO;
+ ret = -EIO;
break;
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked()
2024-07-18 18:30 [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked() Dan Carpenter
@ 2024-07-18 18:37 ` Frank Li
2024-07-23 23:51 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2024-07-18 18:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Miquel Raynal, Conor Culhane, Alexandre Belloni, linux-i3c,
linux-kernel, kernel-janitors
On Thu, Jul 18, 2024 at 01:30:22PM -0500, Dan Carpenter wrote:
> This code has a typo so it returns positive EIO instead of negative -EIO. Fix
> it!
>
> Fixes: a7809cb368b9 ("i3c: master: svc: Improve DAA STOP handle code logic")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index e80c002991f7..0a68fd1b81d4 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -874,7 +874,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
> * address this time.
> */
> if (prov_id[dev_nb] == nacking_prov_id) {
> - ret = EIO;
> + ret = -EIO;
> break;
> }
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked()
2024-07-18 18:30 [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked() Dan Carpenter
2024-07-18 18:37 ` Frank Li
@ 2024-07-23 23:51 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2024-07-23 23:51 UTC (permalink / raw)
To: Frank Li, Dan Carpenter
Cc: Miquel Raynal, Conor Culhane, linux-i3c, linux-kernel, kernel-janitors
On Thu, 18 Jul 2024 13:30:22 -0500, Dan Carpenter wrote:
> This code has a typo so it returns positive EIO instead of negative -EIO. Fix
> it!
>
>
Applied, thanks!
[1/1] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked()
https://git.kernel.org/abelloni/c/82a8702d94fd
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-23 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-18 18:30 [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked() Dan Carpenter
2024-07-18 18:37 ` Frank Li
2024-07-23 23:51 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®