* [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances
@ 2024-09-05 20:12 Nikunj Kela
2024-09-06 0:25 ` Peng Fan
0 siblings, 1 reply; 5+ messages in thread
From: Nikunj Kela @ 2024-09-05 20:12 UTC (permalink / raw)
To: sudeep.holla, robh, krzk+dt, conor+dt
Cc: cristian.marussi, arm-scmi, linux-arm-kernel, devicetree,
linux-kernel, kernel, quic_psodagud, Nikunj Kela,
Krzysztof Kozlowski
This change extends scmi node name so as to allow multiple virtual
SCMI instances.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
---
Changes in v3:
- Added Reviewed-by tag
- Removed the patch from original series[1]
Changes in v2:
- Fixed scmi nodename pattern
[1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/
---
Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
index 54d7d11bfed4..5d79b15a1610 100644
--- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
+++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
@@ -27,7 +27,7 @@ anyOf:
properties:
$nodename:
- const: scmi
+ pattern: '^scmi(-[0-9]+)?$'
compatible:
oneOf:
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances
2024-09-05 20:12 [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances Nikunj Kela
@ 2024-09-06 0:25 ` Peng Fan
2024-09-06 0:33 ` Nikunj Kela
0 siblings, 1 reply; 5+ messages in thread
From: Peng Fan @ 2024-09-06 0:25 UTC (permalink / raw)
To: Nikunj Kela, sudeep.holla, robh, krzk+dt, conor+dt
Cc: cristian.marussi, arm-scmi, linux-arm-kernel, devicetree,
linux-kernel, kernel, quic_psodagud, Krzysztof Kozlowski
> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple
> virtual instances
Just wonder, what do you mean virtual?
Thanks,
Peng.
>
> This change extends scmi node name so as to allow multiple virtual
> SCMI instances.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
> ---
>
> Changes in v3:
> - Added Reviewed-by tag
> - Removed the patch from original series[1]
>
> Changes in v2:
> - Fixed scmi nodename pattern
>
> [1]:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> lore.kernel.org%2Fall%2F20240903220240.2594102-1-
> quic_nkela%40quicinc.com%2F&data=05%7C02%7Cpeng.fan%40nxp.c
> om%7C350f57ac3042490bed0808dccde71b35%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C638611639683033003%7CUnknow
> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=zYYNSdVovTG
> h5BBUqW%2BRNyxoO7EXrUtTppk4MiywowU%3D&reserved=0
> ---
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index 54d7d11bfed4..5d79b15a1610 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -27,7 +27,7 @@ anyOf:
>
> properties:
> $nodename:
> - const: scmi
> + pattern: '^scmi(-[0-9]+)?$'
>
> compatible:
> oneOf:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances
2024-09-06 0:25 ` Peng Fan
@ 2024-09-06 0:33 ` Nikunj Kela
2024-09-06 7:32 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Nikunj Kela @ 2024-09-06 0:33 UTC (permalink / raw)
To: Peng Fan, sudeep.holla, robh, krzk+dt, conor+dt
Cc: cristian.marussi, arm-scmi, linux-arm-kernel, devicetree,
linux-kernel, kernel, quic_psodagud, Krzysztof Kozlowski
On 9/5/2024 5:25 PM, Peng Fan wrote:
>> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple
>> virtual instances
> Just wonder, what do you mean virtual?
Just a term to indicate that these are different SCMI instances within
the same OS. In one of the series from Cristian, he used the term
'virtual SCMI instances' so I used the same term here.
Thanks,
-Nikunj
>
> Thanks,
> Peng.
>
>> This change extends scmi node name so as to allow multiple virtual
>> SCMI instances.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
>> ---
>>
>> Changes in v3:
>> - Added Reviewed-by tag
>> - Removed the patch from original series[1]
>>
>> Changes in v2:
>> - Fixed scmi nodename pattern
>>
>> [1]:
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
>> lore.kernel.org%2Fall%2F20240903220240.2594102-1-
>> quic_nkela%40quicinc.com%2F&data=05%7C02%7Cpeng.fan%40nxp.c
>> om%7C350f57ac3042490bed0808dccde71b35%7C686ea1d3bc2b4c6f
>> a92cd99c5c301635%7C0%7C0%7C638611639683033003%7CUnknow
>> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI
>> 6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=zYYNSdVovTG
>> h5BBUqW%2BRNyxoO7EXrUtTppk4MiywowU%3D&reserved=0
>> ---
>> Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>> b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>> index 54d7d11bfed4..5d79b15a1610 100644
>> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>> @@ -27,7 +27,7 @@ anyOf:
>>
>> properties:
>> $nodename:
>> - const: scmi
>> + pattern: '^scmi(-[0-9]+)?$'
>>
>> compatible:
>> oneOf:
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances
2024-09-06 0:33 ` Nikunj Kela
@ 2024-09-06 7:32 ` Krzysztof Kozlowski
2024-09-06 14:06 ` Nikunj Kela
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-06 7:32 UTC (permalink / raw)
To: Nikunj Kela
Cc: Peng Fan, sudeep.holla, robh, krzk+dt, conor+dt,
cristian.marussi, arm-scmi, linux-arm-kernel, devicetree,
linux-kernel, kernel, quic_psodagud
On Thu, Sep 05, 2024 at 05:33:04PM -0700, Nikunj Kela wrote:
>
> On 9/5/2024 5:25 PM, Peng Fan wrote:
> >> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple
> >> virtual instances
> > Just wonder, what do you mean virtual?
>
> Just a term to indicate that these are different SCMI instances within
> the same OS. In one of the series from Cristian, he used the term
> 'virtual SCMI instances' so I used the same term here.
That's indeed confusing. Virtual means not a real thing...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances
2024-09-06 7:32 ` Krzysztof Kozlowski
@ 2024-09-06 14:06 ` Nikunj Kela
0 siblings, 0 replies; 5+ messages in thread
From: Nikunj Kela @ 2024-09-06 14:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Peng Fan, sudeep.holla, robh, krzk+dt, conor+dt,
cristian.marussi, arm-scmi, linux-arm-kernel, devicetree,
linux-kernel, kernel, quic_psodagud
On 9/6/2024 12:32 AM, Krzysztof Kozlowski wrote:
> On Thu, Sep 05, 2024 at 05:33:04PM -0700, Nikunj Kela wrote:
>> On 9/5/2024 5:25 PM, Peng Fan wrote:
>>>> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple
>>>> virtual instances
>>> Just wonder, what do you mean virtual?
>> Just a term to indicate that these are different SCMI instances within
>> the same OS. In one of the series from Cristian, he used the term
>> 'virtual SCMI instances' so I used the same term here.
> That's indeed confusing. Virtual means not a real thing...
IIUC, SCMI instance mean single instance within an OS however we are
using multiple instances within single OS. That being said, happy to
drop virtual if people find it confusing. I tried to use the same term
which SCMI reviewer's patch series used.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-06 14:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-05 20:12 [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances Nikunj Kela
2024-09-06 0:25 ` Peng Fan
2024-09-06 0:33 ` Nikunj Kela
2024-09-06 7:32 ` Krzysztof Kozlowski
2024-09-06 14:06 ` Nikunj Kela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®