From: Aradhya Bhatia <a-bhatia1@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jyri Sarha <jyri.sarha@iki.fi>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
DRI Development List <dri-devel@lists.freedesktop.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>, Udit Kumar <u-kumar1@ti.com>,
Francesco Dolcini <francesco@dolcini.it>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>,
Randolph Sapp <rs@ti.com>, Devarsh Thakkar <devarsht@ti.com>,
Jayesh Choudhary <j-choudhary@ti.com>,
Jai Luthra <j-luthra@ti.com>
Subject: Re: [PATCH 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter
Date: Mon, 13 May 2024 14:07:44 +0530 [thread overview]
Message-ID: <e0433619-75c7-40bc-aafb-f0a875ea7dc3@ti.com> (raw)
In-Reply-To: <20240512193459.GF17158@pendragon.ideasonboard.com>
Hi Laurent,
Thank you for reviewing the patches!
On 13-May-24 01:04, Laurent Pinchart wrote:
> Hi Aradhya,
>
> Thank you for the patch.
>
> On Sun, May 12, 2024 at 01:00:53AM +0530, Aradhya Bhatia wrote:
>> Add devicetree binding schema for AM625 OLDI Transmitters.
>>
>> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
>> ---
>> .../bindings/display/ti/ti,am625-oldi.yaml | 153 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 154 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml b/Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml
>> new file mode 100644
>> index 000000000000..0a96e600bc0b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml
>> @@ -0,0 +1,153 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/ti/ti,am625-oldi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments AM625 OLDI Transmitter
>> +
>> +maintainers:
>> + - Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>> + - Aradhya Bhatia <a-bhatia1@ti.com>
>> +
>> +description: |
>> + The AM625 TI Keystone OpenLDI transmitter (OLDI TX) supports serialized RGB
>> + pixel data transmission between host and flat panel display over LVDS (Low
>> + Voltage Differential Sampling) interface. The OLDI TX consists of 7-to-1 data
>> + serializers, and 4-data and 1-clock LVDS outputs. It supports the LVDS output
>> + formats "jeida-18", "jeida-24" and "vesa-18", and can accept 24-bit RGB or
>> + padded and un-padded 18-bit RGB bus formats as input.
>> +
>> +properties:
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> + description: serial clock input for the OLDI transmitters
>> +
>> + clock-names:
>> + const: s_clk
>> +
>> + ti,companion-oldi:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle to companion OLDI transmitter. This property is mandatory for the
>> + primarty OLDI TX if the OLDI TXes are expected to work either in dual-lvds
>> + mode or in clone mode. This property should point to the secondary OLDI
>> + TX.
>> +
>> + ti,secondary-oldi:
>> + type: boolean
>> + description: Boolean property to mark an OLDI TX as secondary node.
>> +
>> + ti,oldi-io-ctrl:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle to syscon device node mapping OLDI IO_CTRL registers found in the
>> + control MMR region. This property is needed for OLDI interface to work.
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Parallel RGB input port
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: LVDS output port
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> +allOf:
>> + - if:
>> + properties:
>> + ti,secondary-oldi: true
>> + then:
>> + properties:
>> + ti,companion-oldi: false
>> + ti,oldi-io-ctrl: false
>> + clocks: false
>> + clock-names: false
>> +
>> + else:
>> + required:
>> + - ti,oldi-io-ctrl
>> + - clocks
>> + - clock-names
>> +
>> +required:
>> + - reg
>> + - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
>> +
>> + oldi_txes {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + oldi: oldi@0 {
>> + reg = <0>;
>> + clocks = <&k3_clks 186 0>;
>> + clock-names = "s_clk";
>> + ti,oldi-io-ctrl = <&dss_oldi_io_ctrl>;
>
> What bus does this device live on ? Couldn't the I/O register space be
> referenced by the reg property ?.
>
These registers are a part of the system-controller register space
(ctrl_mmr0). The whole register set is owned by the main_conf[0]
devicetree node, with sub-nodes pointing to specific regions. That's why
I cannot reference these registers directly.
The IO control node for OLDI will look like this though[1].
[0]:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/ti/k3-am62-main.dtsi#n45
[1]:
https://github.com/aradhya07/linux-ab/commit/7d7184fb36dc22c67cc2704fe708e885f300860c
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + port@0 {
>> + reg = <0>;
>> + oldi_in: endpoint {
>> + remote-endpoint = <&dpi0_out>;
>> + };
>> + };
>> + };
>> + };
>> + };
>> +
>
[ ... ]
--
Regards
Aradhya
next prev parent reply other threads:[~2024-05-13 8:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 19:30 [PATCH 0/4] drm/tidss: Add OLDI bridge support Aradhya Bhatia
2024-05-11 19:30 ` [PATCH 1/4] dt-bindings: display: ti,am65x-dss: Minor Cleanup Aradhya Bhatia
2024-05-12 19:25 ` Laurent Pinchart
2024-05-13 19:19 ` Rob Herring
2024-05-14 5:11 ` Aradhya Bhatia
2024-06-27 14:14 ` Tomi Valkeinen
2024-05-11 19:30 ` [PATCH 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter Aradhya Bhatia
2024-05-12 19:34 ` Laurent Pinchart
2024-05-13 8:37 ` Aradhya Bhatia [this message]
2024-05-13 19:30 ` Rob Herring
2024-05-14 5:08 ` Aradhya Bhatia
2024-06-27 14:44 ` Tomi Valkeinen
2024-05-11 19:30 ` [PATCH 3/4] dt-bindings: display: ti,am65x-dss: Add OLDI properties for AM625 DSS Aradhya Bhatia
2024-05-13 19:35 ` Rob Herring
2024-05-14 5:10 ` Aradhya Bhatia
2024-05-11 19:30 ` [PATCH 4/4] drm/tidss: Add OLDI bridge support Aradhya Bhatia
2024-05-12 11:48 ` Francesco Dolcini
2024-05-12 15:23 ` Aradhya Bhatia
2024-05-12 16:44 ` Francesco Dolcini
2024-06-27 13:11 ` Tomi Valkeinen
2024-07-15 10:02 ` Aradhya Bhatia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0433619-75c7-40bc-aafb-f0a875ea7dc3@ti.com \
--to=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=alexander.sverdlin@siemens.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=francesco@dolcini.it \
--cc=j-choudhary@ti.com \
--cc=j-luthra@ti.com \
--cc=jyri.sarha@iki.fi \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=rs@ti.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®