mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist
@ 2025-01-09 21:07 Povilas Kanapickas
  2025-01-09 23:24 ` Armin Wolf
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Povilas Kanapickas @ 2025-01-09 21:07 UTC (permalink / raw)
  To: pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel

Add the Dell XPS 9370 to the fan control whitelist to allow
for manual fan control.

Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
---

Notes:
    v1->v2:
    * Use I8K_FAN_30A3_31A3 call instead of I8K_FAN_34A3_35A3.

 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index f5bdf842040e..cd00adaad1b4 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 9370",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
+	},
 	{
 		.ident = "Dell Optiplex 7000",
 		.matches = {
-- 
2.39.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist
  2025-01-09 21:07 [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist Povilas Kanapickas
@ 2025-01-09 23:24 ` Armin Wolf
  2025-01-09 23:26 ` Pali Rohár
  2025-01-09 23:44 ` Guenter Roeck
  2 siblings, 0 replies; 4+ messages in thread
From: Armin Wolf @ 2025-01-09 23:24 UTC (permalink / raw)
  To: Povilas Kanapickas, pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel

Am 09.01.25 um 22:07 schrieb Povilas Kanapickas:

> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

>
> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
> ---
>
> Notes:
>      v1->v2:
>      * Use I8K_FAN_30A3_31A3 call instead of I8K_FAN_34A3_35A3.
>
>   drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f5bdf842040e..cd00adaad1b4 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
>   		},
>   		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>   	},
> +	{
> +		.ident = "Dell XPS 13 9370",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
> +		},
> +		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> +	},
>   	{
>   		.ident = "Dell Optiplex 7000",
>   		.matches = {

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist
  2025-01-09 21:07 [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist Povilas Kanapickas
  2025-01-09 23:24 ` Armin Wolf
@ 2025-01-09 23:26 ` Pali Rohár
  2025-01-09 23:44 ` Guenter Roeck
  2 siblings, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2025-01-09 23:26 UTC (permalink / raw)
  To: Povilas Kanapickas; +Cc: jdelvare, linux, linux-hwmon, linux-kernel

On Thursday 09 January 2025 23:07:00 Povilas Kanapickas wrote:
> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.
> 
> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>

Acked-by: Pali Rohár <pali@kernel.org>

> ---
> 
> Notes:
>     v1->v2:
>     * Use I8K_FAN_30A3_31A3 call instead of I8K_FAN_34A3_35A3.
> 
>  drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f5bdf842040e..cd00adaad1b4 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
>  		},
>  		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>  	},
> +	{
> +		.ident = "Dell XPS 13 9370",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
> +		},
> +		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> +	},
>  	{
>  		.ident = "Dell Optiplex 7000",
>  		.matches = {
> -- 
> 2.39.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist
  2025-01-09 21:07 [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist Povilas Kanapickas
  2025-01-09 23:24 ` Armin Wolf
  2025-01-09 23:26 ` Pali Rohár
@ 2025-01-09 23:44 ` Guenter Roeck
  2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2025-01-09 23:44 UTC (permalink / raw)
  To: Povilas Kanapickas; +Cc: pali, jdelvare, linux-hwmon, linux-kernel

On Thu, Jan 09, 2025 at 11:07:00PM +0200, Povilas Kanapickas wrote:
> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.
> 
> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
> Acked-by: Pali Rohár <pali@kernel.org>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-01-09 23:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-09 21:07 [PATCH v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist Povilas Kanapickas
2025-01-09 23:24 ` Armin Wolf
2025-01-09 23:26 ` Pali Rohár
2025-01-09 23:44 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®