* [PATCH] power: cpupower: utils: Add malloc return value check
@ 2022-10-14 4:29 Li kunyu
2022-10-18 20:33 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Li kunyu @ 2022-10-14 4:29 UTC (permalink / raw)
To: shuah; +Cc: trenn, ray.huang, linux-pm, linux-kernel, Li kunyu
Add the check and judgment statement of malloc return value.
Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
tools/power/cpupower/utils/helpers/misc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
index 9547b29254a7..eafdbd6d760c 100644
--- a/tools/power/cpupower/utils/helpers/misc.c
+++ b/tools/power/cpupower/utils/helpers/misc.c
@@ -139,6 +139,8 @@ void print_online_cpus(void)
str_len = online_cpus->size * 5;
online_cpus_str = (void *)malloc(sizeof(char) * str_len);
+ if (unlikely(!online_cpus_str))
+ return;
if (!bitmask_isallclear(online_cpus)) {
bitmask_displaylist(online_cpus_str, str_len, online_cpus);
@@ -157,6 +159,8 @@ void print_offline_cpus(void)
str_len = offline_cpus->size * 5;
offline_cpus_str = (void *)malloc(sizeof(char) * str_len);
+ if (unlikely(!offline_cpus_str))
+ return;
if (!bitmask_isallclear(offline_cpus)) {
bitmask_displaylist(offline_cpus_str, str_len, offline_cpus);
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] power: cpupower: utils: Add malloc return value check
2022-10-14 4:29 [PATCH] power: cpupower: utils: Add malloc return value check Li kunyu
@ 2022-10-18 20:33 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2022-10-18 20:33 UTC (permalink / raw)
To: Li kunyu, shuah; +Cc: trenn, ray.huang, linux-pm, linux-kernel, Shuah Khan
On 10/13/22 22:29, Li kunyu wrote:
> Add the check and judgment statement of malloc return value.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> tools/power/cpupower/utils/helpers/misc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9547b29254a7..eafdbd6d760c 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -139,6 +139,8 @@ void print_online_cpus(void)
>
> str_len = online_cpus->size * 5;
> online_cpus_str = (void *)malloc(sizeof(char) * str_len);
> + if (unlikely(!online_cpus_str))
> + return;
You don't need unlikely here.
>
> if (!bitmask_isallclear(online_cpus)) {
> bitmask_displaylist(online_cpus_str, str_len, online_cpus);
> @@ -157,6 +159,8 @@ void print_offline_cpus(void)
>
> str_len = offline_cpus->size * 5;
> offline_cpus_str = (void *)malloc(sizeof(char) * str_len);
> + if (unlikely(!offline_cpus_str))
> + return;
You don't need unlikely here.
>
> if (!bitmask_isallclear(offline_cpus)) {
> bitmask_displaylist(offline_cpus_str, str_len, offline_cpus);
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-18 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-14 4:29 [PATCH] power: cpupower: utils: Add malloc return value check Li kunyu
2022-10-18 20:33 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®