Re: [PATCH v4 2/4] arm64: dts: qcom: Enable USB controllers on Shikra CQS platform

[Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>]

On 7/22/2026 11:03 AM, Dmitry Baryshkov wrote:
> On Wed, Jul 22, 2026 at 07:22:47AM +0530, Krishna Kurapati wrote:
>>
>>
>> On 7/22/2026 3:07 AM, Dmitry Baryshkov wrote:
>>> On Tue, Jul 21, 2026 at 03:23:46PM +0530, Krishna Kurapati wrote:
>>>> Enable both USB controllers in device mode on Shikra CQS platform.
>>>>
>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 35 +++++++++++++++++++++++++++++
>>>>    1 file changed, 35 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
>>>> index b3f19a64d7ae..006e24a62f5c 100644
>>>> --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
>>>> @@ -38,3 +38,38 @@ &sdhc_1 {
>>>>    	status = "okay";
>>>>    };
>>>> +
>>>> +&usb_1 {
>>>> +	dr_mode = "peripheral";
>>>
>>> Why is peripheral-only?
>>>
>>
>> On First controller of CQS/CQM platforms, usb-role-swtich is controller by
>> PM4125 and on second controller of CQS/CQM platforms, and both controllers
>> of IQS, its controller by Cypress PD controller. I will push out the PM4125
>> changes in a different patch set since couple of issues are under debug. And
>> the cypress pd controller changes are still under development. Hence enabled
>> both controllers in device mode for now.
> 
> That needs to be explained in the commit messages.
> 

Since putting in commit message that there is a PD controller or the 
PM4125 will take care of OTG would be out of context, in cover letter 
can i mention that the above information, and state that future patches 
will enable OTG.

Regards,
Krishna,