mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
	Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
	Hans Verkuil <hans.verkuil@cisco.com>
Subject: [PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings using forward declaration
Date: Fri,  7 Jul 2017 12:08:05 +0100	[thread overview]
Message-ID: <e0e455ac3f40b3dd0344127bbb8773cea579620e.1499425271.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1499425271.git.joabreu@synopsys.com>
In-Reply-To: <cover.1499425271.git.joabreu@synopsys.com>

When CONFIC_CEC_NOTIFIER is not set and we only include cec-notifier.h
we can get build warnings like these ones:

"warning: ‘struct cec_notifier’ declared inside parameter list will
not be visible outside of this definition or declaration"

Prevent these warnings by using forward declaration of notifier
structure.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Carlos Palminha <palminha@synopsys.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
---
 include/media/cec-notifier.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/media/cec-notifier.h b/include/media/cec-notifier.h
index 298f996..84f9376 100644
--- a/include/media/cec-notifier.h
+++ b/include/media/cec-notifier.h
@@ -21,14 +21,14 @@
 #ifndef LINUX_CEC_NOTIFIER_H
 #define LINUX_CEC_NOTIFIER_H
 
-#include <linux/types.h>
-#include <media/cec.h>
-
 struct device;
 struct edid;
 struct cec_adapter;
 struct cec_notifier;
 
+#include <linux/types.h>
+#include <media/cec.h>
+
 #if IS_REACHABLE(CONFIG_CEC_CORE) && IS_ENABLED(CONFIG_CEC_NOTIFIER)
 
 /**
-- 
1.9.1

  parent reply	other threads:[~2017-07-07 11:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 11:08 [PATCH v7 0/6] Synopsys Designware HDMI Video Capture Controller + PHY Jose Abreu
2017-07-07 11:08 ` [PATCH v7 1/6] [media] cec.h: Add stub function for cec_register_cec_notifier() Jose Abreu
2017-07-07 11:08 ` Jose Abreu [this message]
2017-07-07 11:16   ` [PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings using forward declaration Hans Verkuil
2017-07-07 11:25     ` Jose Abreu
2017-07-07 11:08 ` [PATCH v7 3/6] dt-bindings: media: Document Synopsys Designware HDMI RX Jose Abreu
2017-07-07 11:08 ` [PATCH v7 4/6] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers Jose Abreu
2017-07-07 11:08 ` [PATCH v7 5/6] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver Jose Abreu
2017-07-07 11:08 ` [PATCH v7 6/6] [media] platform: Add Synopsys Designware HDMI RX Controller Driver Jose Abreu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0e455ac3f40b3dd0344127bbb8773cea579620e.1499425271.git.joabreu@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®