Re: [PATCH v2 1/2] media: s2255: Rename CamelCase goto labels to snake_case

[hverkuil+cisco@kernel.org]

On 15/07/2026 12:00, Johan Hovold wrote:
> On Wed, Jul 15, 2026 at 05:29:46PM +0800, Lei Huang wrote:
>> From: Lei Huang <huanglei@kylinos.cn>
>>
>> Rename the error-path goto labels in s2255_probe() from CamelCase to
>> snake_case to comply with the Linux kernel coding style:
>>
>>   errorBOARDINIT -> err_boardinit
>>   errorFWMARKER  -> err_fwmarker
>>   errorREQFW     -> err_reqfw
>>   errorFWDATA2   -> err_fwdata2
>>   errorFWURB     -> err_fwurb
>>   errorEP        -> err_ep
>>   errorUDEV      -> err_udev
>>   errorFWDATA1   -> err_fwdata1
>>
>> No functional changes; all label definitions and goto references are
>> updated consistently.
>>
>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
> 
> This looks ok, but the fix should go before the cleanup (e.g. to
> facilitate backporting).

I'll just take the v1 patch and Lei Huang can make a cleanup patch on
top of that. It is nice to get rid of the camelCase labels.

Regards,

	Hans

> 
> Also, always include a changelog (in a coverletter) when updating a
> series.
> 
> Johan
>