From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Rob Herring <robh@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: amlogic: convert amlogic,gxbb-aoclkc.txt to dt-schema
Date: Thu, 6 Jul 2023 09:51:34 +0200 [thread overview]
Message-ID: <e1e12c86-da0d-0ae0-0542-86bdc4c81bb3@linaro.org> (raw)
In-Reply-To: <1jttuh5www.fsf@starbuckisacylon.baylibre.com>
On 06/07/2023 09:15, Jerome Brunet wrote:
>>> + then:
>>> + properties:
>>> + clock-names:
>>> + minItems: 2
>>> + items:
>>> + - const: xtal
>>> + - const: mpeg-clk
>>> + - const: ext-32k-0
>>> + - const: ext-32k-1
>>> + - const: ext-32k-2
>>
>> As the names are always the same, move this to top-level and just set
>> the length here (except the constraints are the same as top-level, so
>> you can just drop this if/then).
>
> If this is done, aren't we losing information ?
>
> For example, "ext-32k-1" would become valid with a g12a as long as the
> number of clocks is alright, which it is not.
How it would be valid? It would be fourth item but only three are allowed.
>
> I'm not concerned by the automated verification, more the information
> provided to the users, which we used to have in the txt format.
No information is lost here, unless you claim that entries are entirely
different?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-06 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 11:41 [PATCH v2 0/3] dt-bindings: second batch of dt-schema conversions for Amlogic Meson bindings Neil Armstrong
2023-07-05 11:41 ` [PATCH v2 1/3] dt-bindings: clock: amlogic: convert amlogic,gxbb-clkc.txt to dt-schema Neil Armstrong
2023-07-05 19:53 ` Rob Herring
2023-07-05 11:41 ` [PATCH v2 2/3] dt-bindings: clock: amlogic: convert amlogic,gxbb-aoclkc.txt " Neil Armstrong
2023-07-05 19:56 ` Rob Herring
2023-07-06 7:15 ` Jerome Brunet
2023-07-06 7:51 ` Krzysztof Kozlowski [this message]
2023-07-06 8:03 ` Jerome Brunet
2023-07-05 11:41 ` [PATCH v2 3/3] dt-bindings: soc: amlogic: document System Control registers Neil Armstrong
2023-07-05 19:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1e12c86-da0d-0ae0-0542-86bdc4c81bb3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®