From: Timo Alho <talho@nvidia.com>
To: Jonathan Hunter <jonathanh@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] firmware: tegra: add BPMP debugfs support
Date: Mon, 2 Oct 2017 11:36:23 +0300 [thread overview]
Message-ID: <e1e20e48-11a1-9b57-01a8-8eacef878571@nvidia.com> (raw)
In-Reply-To: <2a51649c-99d3-4e72-9a81-e93aec8f72de@nvidia.com>
On 29.09.2017 17:58, Jonathan Hunter wrote:
>>>> +static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf
>>>> *seqbuf,
>>>> + struct dentry *parent, uint32_t depth)
>>>
>>> Do we need to use uint32_t here?
>>>
>>>> +{
>>>> + int err;
>>>> + uint32_t d, t;
>>>
>>> And here?
>>
>> It's part of the BPMP ABI that the data passed is 32 bit unsigned
>> integer. I wanted to emphasise that with the choice of integer type. Or
>> did you mean why I did not use u32?
>
> Yes why not just u32?
>
No other reason than just a personal bias to use standard C99 integer
types. The downstream driver was using a mix of both so wanted to
standardize to just one.
prev parent reply other threads:[~2017-10-02 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 14:04 Timo Alho
2017-09-21 11:10 ` Jon Hunter
2017-09-29 13:41 ` Timo Alho
2017-09-29 14:58 ` Jon Hunter
2017-10-02 8:36 ` Timo Alho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1e20e48-11a1-9b57-01a8-8eacef878571@nvidia.com \
--to=talho@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®