mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sridharan S N <quic_sridsn@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<agross@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons
Date: Wed, 31 May 2023 13:33:27 +0530	[thread overview]
Message-ID: <e1ea1f6c-ea13-0766-b946-accb801c9f84@quicinc.com> (raw)
In-Reply-To: <46639d7e-95ed-35a6-a9ab-d802af4470ce@linaro.org>


On 5/31/2023 12:45 PM, Krzysztof Kozlowski wrote:
> On 31/05/2023 08:56, Sridharan S N wrote:
>> Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35.
>>
>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 43 +++++++++++++++++++++
>>   arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts | 43 +++++++++++++++++++++
>>   arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 43 +++++++++++++++++++++
>>   3 files changed, 129 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
>> index 3af1d5556950..ba733b6cab06 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
>> @@ -7,6 +7,8 @@
>>   
>>   /dts-v1/;
>>   
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>>   #include "ipq5332.dtsi"
>>   
>>   / {
>> @@ -20,6 +22,33 @@
>>   	chosen {
>>   		stdout-path = "serial0";
>>   	};
>> +
>> +	gpio_keys {
> No underscores in node names.
Will address it in V2
>
>> +		compatible = "gpio-keys";
>> +		pinctrl-0 = <&gpio_keys_default>;
>> +		pinctrl-names = "default";
>> +		status = "okay";
> It's by default, why do you need it?
Will address it in V2
>
>
>
> Best regards,
> Krzysztof
>

  reply	other threads:[~2023-05-31  8:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31  6:56 [PATCH 0/2] Add support for GPIO based leds and buttons Sridharan S N
2023-05-31  6:56 ` [PATCH 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N
2023-05-31  7:15   ` Krzysztof Kozlowski
2023-05-31  8:03     ` Sridharan S N [this message]
2023-05-31  6:56 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Sridharan S N
2023-06-15 14:28 [PATCH V3 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Sridharan S N
2023-06-15 14:28 ` [PATCH 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1ea1f6c-ea13-0766-b946-accb801c9f84@quicinc.com \
    --to=quic_sridsn@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®