* [PATCH] thermal/drivers/qcom: Remove some unused fields in struct qpnp_tm_chip
@ 2024-04-09 19:56 Christophe JAILLET
2024-04-11 3:15 ` Bjorn Andersson
2024-04-22 16:23 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-04-09 19:56 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-pm,
linux-arm-msm
In "struct qpnp_tm_chip", the 'prev_stage' field is unused.
Remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
Apparently, it has never been used. It is not a left-over from a
refactoring.
---
drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
index 78c5cfe6a0c0..3cd74f6cac8f 100644
--- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
+++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
@@ -74,7 +74,6 @@ struct qpnp_tm_chip {
long temp;
unsigned int thresh;
unsigned int stage;
- unsigned int prev_stage;
unsigned int base;
/* protects .thresh, .stage and chip registers */
struct mutex lock;
--
2.44.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/qcom: Remove some unused fields in struct qpnp_tm_chip
2024-04-09 19:56 [PATCH] thermal/drivers/qcom: Remove some unused fields in struct qpnp_tm_chip Christophe JAILLET
@ 2024-04-11 3:15 ` Bjorn Andersson
2024-04-22 16:23 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-04-11 3:15 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, linux-kernel, kernel-janitors, linux-pm,
linux-arm-msm
On Tue, Apr 09, 2024 at 09:56:34PM +0200, Christophe JAILLET wrote:
> In "struct qpnp_tm_chip", the 'prev_stage' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> Compile tested only.
>
> Apparently, it has never been used. It is not a left-over from a
> refactoring.
> ---
> drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> index 78c5cfe6a0c0..3cd74f6cac8f 100644
> --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> @@ -74,7 +74,6 @@ struct qpnp_tm_chip {
> long temp;
> unsigned int thresh;
> unsigned int stage;
> - unsigned int prev_stage;
> unsigned int base;
> /* protects .thresh, .stage and chip registers */
> struct mutex lock;
> --
> 2.44.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/qcom: Remove some unused fields in struct qpnp_tm_chip
2024-04-09 19:56 [PATCH] thermal/drivers/qcom: Remove some unused fields in struct qpnp_tm_chip Christophe JAILLET
2024-04-11 3:15 ` Bjorn Andersson
@ 2024-04-22 16:23 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2024-04-22 16:23 UTC (permalink / raw)
To: Christophe JAILLET, Amit Kucheria, Thara Gopinath,
Rafael J. Wysocki, Zhang Rui, Lukasz Luba
Cc: linux-kernel, kernel-janitors, linux-pm, linux-arm-msm
On 09/04/2024 21:56, Christophe JAILLET wrote:
> In "struct qpnp_tm_chip", the 'prev_stage' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-22 16:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-09 19:56 [PATCH] thermal/drivers/qcom: Remove some unused fields in struct qpnp_tm_chip Christophe JAILLET
2024-04-11 3:15 ` Bjorn Andersson
2024-04-22 16:23 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®