* [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini()
@ 2022-11-22 3:05 YueHaibing
2022-11-22 3:12 ` YueHaibing
0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2022-11-22 3:05 UTC (permalink / raw)
To: s.shtylyov, davem, edumazet, kuba, pabeni, yoshihiro.shimoda.uh
Cc: netdev, linux-renesas-soc, linux-kernel, YueHaibing
cc_debugfs_global_fini() is marked with __exit now, however it is used
in __init ccree_init() for cleanup. Remove the __exit annotation to fix
build warning:
WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in reference: init_module (section: .init.text) -> cc_debugfs_global_fini (section: .exit.text)
Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/crypto/ccree/cc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccree/cc_debugfs.c b/drivers/crypto/ccree/cc_debugfs.c
index 7083767602fc..8f008f024f8f 100644
--- a/drivers/crypto/ccree/cc_debugfs.c
+++ b/drivers/crypto/ccree/cc_debugfs.c
@@ -55,7 +55,7 @@ void __init cc_debugfs_global_init(void)
cc_debugfs_dir = debugfs_create_dir("ccree", NULL);
}
-void __exit cc_debugfs_global_fini(void)
+void cc_debugfs_global_fini(void)
{
debugfs_remove(cc_debugfs_dir);
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini()
2022-11-22 3:05 [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini() YueHaibing
@ 2022-11-22 3:12 ` YueHaibing
2022-11-22 11:24 ` Biju Das
0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2022-11-22 3:12 UTC (permalink / raw)
To: s.shtylyov, davem, edumazet, kuba, pabeni, yoshihiro.shimoda.uh
Cc: netdev, linux-renesas-soc, linux-kernel
Sorry， Pls ignore this.
On 2022/11/22 11:05, YueHaibing wrote:
> cc_debugfs_global_fini() is marked with __exit now, however it is used
> in __init ccree_init() for cleanup. Remove the __exit annotation to fix
> build warning:
>
> WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in reference: init_module (section: .init.text) -> cc_debugfs_global_fini (section: .exit.text)
>
> Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/crypto/ccree/cc_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccree/cc_debugfs.c b/drivers/crypto/ccree/cc_debugfs.c
> index 7083767602fc..8f008f024f8f 100644
> --- a/drivers/crypto/ccree/cc_debugfs.c
> +++ b/drivers/crypto/ccree/cc_debugfs.c
> @@ -55,7 +55,7 @@ void __init cc_debugfs_global_init(void)
> cc_debugfs_dir = debugfs_create_dir("ccree", NULL);
> }
>
> -void __exit cc_debugfs_global_fini(void)
> +void cc_debugfs_global_fini(void)
> {
> debugfs_remove(cc_debugfs_dir);
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini()
2022-11-22 3:12 ` YueHaibing
@ 2022-11-22 11:24 ` Biju Das
2022-11-22 11:31 ` YueHaibing
0 siblings, 1 reply; 6+ messages in thread
From: Biju Das @ 2022-11-22 11:24 UTC (permalink / raw)
To: YueHaibing, s.shtylyov, davem, edumazet, kuba, pabeni, Yoshihiro Shimoda
Cc: netdev, linux-renesas-soc, linux-kernel
> Subject: Re: [PATCH -next] crypto: ccree - Fix section mismatch due to
> cc_debugfs_global_fini()
>
> Sorry， Pls ignore this.
This is real issue, right?
"WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in
reference: init_module (section: .init.text) -> cc_debugfs_global_fini
(section: .exit.text)"
Looks like the committer of the patch without building submitted the patch.
4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
Cheers,
Biju
>
> On 2022/11/22 11:05, YueHaibing wrote:
> > cc_debugfs_global_fini() is marked with __exit now, however it is used
> > in __init ccree_init() for cleanup. Remove the __exit annotation to
> > fix build warning:
> >
> > WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in
> > reference: init_module (section: .init.text) -> cc_debugfs_global_fini
> > (section: .exit.text)
> >
> > Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when
> > platform_driver_register failed")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/crypto/ccree/cc_debugfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/ccree/cc_debugfs.c
> > b/drivers/crypto/ccree/cc_debugfs.c
> > index 7083767602fc..8f008f024f8f 100644
> > --- a/drivers/crypto/ccree/cc_debugfs.c
> > +++ b/drivers/crypto/ccree/cc_debugfs.c
> > @@ -55,7 +55,7 @@ void __init cc_debugfs_global_init(void)
> > cc_debugfs_dir = debugfs_create_dir("ccree", NULL); }
> >
> > -void __exit cc_debugfs_global_fini(void)
> > +void cc_debugfs_global_fini(void)
> > {
> > debugfs_remove(cc_debugfs_dir);
> > }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini()
2022-11-22 11:24 ` Biju Das
@ 2022-11-22 11:31 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2022-11-22 11:31 UTC (permalink / raw)
To: Biju Das, s.shtylyov, davem, edumazet, kuba, pabeni, Yoshihiro Shimoda
Cc: netdev, linux-renesas-soc, linux-kernel
On 2022/11/22 19:24, Biju Das wrote:
>> Subject: Re: [PATCH -next] crypto: ccree - Fix section mismatch due to
>> cc_debugfs_global_fini()
>>
>> Sorry， Pls ignore this.
>
> This is real issue, right?
>
> "WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in
> reference: init_module (section: .init.text) -> cc_debugfs_global_fini
> (section: .exit.text)"
>
>
> Looks like the committer of the patch without building submitted the patch.
> 4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
>
Yes, I send the patch to wrong mail list. A new version has sent.
https://lore.kernel.org/lkml/20221122030555.26612-1-yuehaibing@huawei.com/
> Cheers,
> Biju
>
>
>>
>> On 2022/11/22 11:05, YueHaibing wrote:
>>> cc_debugfs_global_fini() is marked with __exit now, however it is used
>>> in __init ccree_init() for cleanup. Remove the __exit annotation to
>>> fix build warning:
>>>
>>> WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in
>>> reference: init_module (section: .init.text) -> cc_debugfs_global_fini
>>> (section: .exit.text)
>>>
>>> Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when
>>> platform_driver_register failed")
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>> drivers/crypto/ccree/cc_debugfs.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/crypto/ccree/cc_debugfs.c
>>> b/drivers/crypto/ccree/cc_debugfs.c
>>> index 7083767602fc..8f008f024f8f 100644
>>> --- a/drivers/crypto/ccree/cc_debugfs.c
>>> +++ b/drivers/crypto/ccree/cc_debugfs.c
>>> @@ -55,7 +55,7 @@ void __init cc_debugfs_global_init(void)
>>> cc_debugfs_dir = debugfs_create_dir("ccree", NULL); }
>>>
>>> -void __exit cc_debugfs_global_fini(void)
>>> +void cc_debugfs_global_fini(void)
>>> {
>>> debugfs_remove(cc_debugfs_dir);
>>> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini()
@ 2022-11-22 3:05 YueHaibing
2022-11-22 9:07 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2022-11-22 3:05 UTC (permalink / raw)
To: gilad, herbert, davem, yuehaibing, cuigaosheng1
Cc: linux-crypto, linux-kernel
cc_debugfs_global_fini() is marked with __exit now, however it is used
in __init ccree_init() for cleanup. Remove the __exit annotation to fix
build warning:
WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in reference: init_module (section: .init.text) -> cc_debugfs_global_fini (section: .exit.text)
Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/crypto/ccree/cc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccree/cc_debugfs.c b/drivers/crypto/ccree/cc_debugfs.c
index 7083767602fc..8f008f024f8f 100644
--- a/drivers/crypto/ccree/cc_debugfs.c
+++ b/drivers/crypto/ccree/cc_debugfs.c
@@ -55,7 +55,7 @@ void __init cc_debugfs_global_init(void)
cc_debugfs_dir = debugfs_create_dir("ccree", NULL);
}
-void __exit cc_debugfs_global_fini(void)
+void cc_debugfs_global_fini(void)
{
debugfs_remove(cc_debugfs_dir);
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini()
2022-11-22 3:05 YueHaibing
@ 2022-11-22 9:07 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2022-11-22 9:07 UTC (permalink / raw)
To: YueHaibing
Cc: gilad, herbert, davem, cuigaosheng1, linux-crypto, linux-kernel
On Tue, Nov 22, 2022 at 4:12 AM YueHaibing <yuehaibing@huawei.com> wrote:
> cc_debugfs_global_fini() is marked with __exit now, however it is used
> in __init ccree_init() for cleanup. Remove the __exit annotation to fix
> build warning:
>
> WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in reference: init_module (section: .init.text) -> cc_debugfs_global_fini (section: .exit.text)
>
> Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-22 11:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 3:05 [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global_fini() YueHaibing
2022-11-22 3:12 ` YueHaibing
2022-11-22 11:24 ` Biju Das
2022-11-22 11:31 ` YueHaibing
2022-11-22 3:05 YueHaibing
2022-11-22 9:07 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®