From: "Arnd Bergmann" <arnd@kernel.org>
To: "kernel test robot" <yujie.liu@intel.com>,
"Niklas Schnelle" <schnelle@linux.ibm.com>
Cc: oe-lkp@lists.linux.dev, "kernel test robot" <lkp@intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [niks:has_ioport_v3] [tty] aa0652d7f1: BUG:kernel_NULL_pointer_dereference,address
Date: Thu, 05 Jan 2023 09:03:40 +0100 [thread overview]
Message-ID: <e211f932-77c3-427a-859a-d846598524ed@app.fastmail.com> (raw)
In-Reply-To: <202301051008.a8468257-yujie.liu@intel.com>
On Thu, Jan 5, 2023, at 06:54, kernel test robot wrote:
> Greeting,
>
> FYI, we noticed BUG:kernel_NULL_pointer_dereference,address due to
> commit (built with clang-14):
>
> commit: aa0652d7f1b311e55232a8153522fdaaba0f197a ("tty: serial: handle
> HAS_IOPORT dependencies")
> https://git.kernel.org/cgit/linux/kernel/git/niks/linux.git
> has_ioport_v3
>
> in testcase: boot
>
> on test machine: qemu-system-i386 -enable-kvm -cpu SandyBridge -smp 2 -m 4G
>
> caused below changes (please refer to attached dmesg/kmsg for entire
> log/backtrace):
>
>
> [ 2.166733][ T0] calling univ8250_console_init+0x0/0x30 @ 0
> [ 2.167555][ T0] BUG: kernel NULL pointer dereference, address:
> 00000000
I think it's this bit:
@@ -508,12 +523,13 @@ static void set_io_from_upio(struct uart_port *p)
up->dl_read = au_serial_dl_read;
up->dl_write = au_serial_dl_write;
break;
-#endif
-
+#ifdef CONFIG_HAS_IOPORT
default:
p->serial_in = io_serial_in;
p->serial_out = io_serial_out;
break;
+#endif
+#endif
}
/* Remember loaded iotype */
up->cur_iotype = p->iotype;
which puts the 'default' case inside of '#ifdef
CONFIG_SERIAL_8250_RT288X'. x86 does not use the
RT288x variant but relies on the default, so any
call to io_serial_{in,out} will cause a NULL
pointer dereference.
Arnd
next prev parent reply other threads:[~2023-01-05 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 5:54 kernel test robot
2023-01-05 8:03 ` Arnd Bergmann [this message]
2023-01-09 8:45 ` Niklas Schnelle
2023-03-08 11:24 ` Niklas Schnelle
2023-03-08 12:21 ` Arnd Bergmann
2023-03-08 14:03 ` Niklas Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e211f932-77c3-427a-859a-d846598524ed@app.fastmail.com \
--to=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=schnelle@linux.ibm.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®