From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Vitaly Lubart <lubvital@gmail.com>,
Alexander Usyskin <alexander.usyskin@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] misc: issei: hw_heci: fix dev_err format warnings
Date: Wed, 29 Jul 2026 22:03:49 -0700 [thread overview]
Message-ID: <e292cbaf-9c55-45cb-92fa-168b258dace8@infradead.org> (raw)
In-Reply-To: <20260730042227.595683-1-rdunlap@infradead.org>
On 7/29/26 9:22 PM, Randy Dunlap wrote:
> Use "%u" instead of "%lu" to prevent dev_err format warnings:
>
> In file included from ../drivers/misc/issei/hw_heci.c:7:
> ../drivers/misc/issei/hw_heci.c: In function ‘heci_write_hbuf’:
> ../drivers/misc/issei/hw_heci.c:374:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
> 374 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/misc/issei/hw_heci.c: In function ‘heci_read_hbuf’:
> ../drivers/misc/issei/hw_heci.c:404:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
> 404 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 8bf5e84998c3 ("issei: add heci hardware module")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Vitaly Lubart <lubvital@gmail.com>
> Cc: Alexander Usyskin <alexander.usyskin@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
>
> drivers/misc/issei/hw_heci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20260729.orig/drivers/misc/issei/hw_heci.c
> +++ linux-next-20260729/drivers/misc/issei/hw_heci.c
> @@ -371,7 +371,7 @@ static int heci_write_hbuf(struct issei_
> struct issei_heci_hw *hw = to_heci_hw(idev);
>
> if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) {
> - dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> + dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n",
> data_len, CB_SLOT_SIZE);
> return -EINVAL;
> }
> @@ -401,7 +401,7 @@ static int heci_read_hbuf(struct issei_d
> u32 *reg_buf = data;
>
> if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) {
> - dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> + dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n",
> data_len, CB_SLOT_SIZE);
> return -EINVAL;
> }
Please ignore for now.
I get conflicting reports before/after this patch. (!?)
--
~Randy
prev parent reply other threads:[~2026-07-30 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 4:22 Randy Dunlap
2026-07-30 5:03 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e292cbaf-9c55-45cb-92fa-168b258dace8@infradead.org \
--to=rdunlap@infradead.org \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lubvital@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®