[PATCH] fs/gfs2: remove IS_DINODE

[PATCH] fs/gfs2: remove IS_DINODE

[Alex Shi]

After commit 1579343a73e3 ("GFS2: Remove dirent_first() function"), this
macro isn't used any more. so remove it.

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Bob Peterson <rpeterso@redhat.com> 
Cc: Andreas Gruenbacher <agruenba@redhat.com> 
Cc: cluster-devel@redhat.com 
Cc: linux-kernel@vger.kernel.org 
---
 fs/gfs2/dir.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index eb9c0578978f..636a8d0f3dab 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -74,7 +74,6 @@
 #include "util.h"
 
 #define IS_LEAF     1 /* Hashed (leaf) directory */
-#define IS_DINODE   2 /* Linear (stuffed dinode block) directory */
 
 #define MAX_RA_BLOCKS 32 /* max read-ahead blocks */
 
-- 
1.8.3.1

Re: [PATCH] fs/gfs2: remove IS_DINODE

[Andreas Grünbacher]

Alex,

Am Di., 21. Jan. 2020 um 09:50 Uhr schrieb Alex Shi
<alex.shi@linux.alibaba.com>:
> After commit 1579343a73e3 ("GFS2: Remove dirent_first() function"), this
> macro isn't used any more. so remove it.
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Bob Peterson <rpeterso@redhat.com>
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: cluster-devel@redhat.com
> Cc: linux-kernel@vger.kernel.org
> ---
>  fs/gfs2/dir.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index eb9c0578978f..636a8d0f3dab 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -74,7 +74,6 @@
>  #include "util.h"
>
>  #define IS_LEAF     1 /* Hashed (leaf) directory */
> -#define IS_DINODE   2 /* Linear (stuffed dinode block) directory */

The same is true for the IS_LEAF macro. I'm adjusting the patch accordingly.

The other patch removing the LBIT macros looks good as well, so I'm
applying both.

Thanks,
Andreas

Re: [PATCH] fs/gfs2: remove IS_DINODE

[Alex Shi]

在 2020/1/21 下午6:23, Andreas Grünbacher 写道:
> Alex,
> 
> Am Di., 21. Jan. 2020 um 09:50 Uhr schrieb Alex Shi
> <alex.shi@linux.alibaba.com>:
>> After commit 1579343a73e3 ("GFS2: Remove dirent_first() function"), this
>> macro isn't used any more. so remove it.
>>
>> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
>> Cc: Bob Peterson <rpeterso@redhat.com>
>> Cc: Andreas Gruenbacher <agruenba@redhat.com>
>> Cc: cluster-devel@redhat.com
>> Cc: linux-kernel@vger.kernel.org
>> ---
>>  fs/gfs2/dir.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
>> index eb9c0578978f..636a8d0f3dab 100644
>> --- a/fs/gfs2/dir.c
>> +++ b/fs/gfs2/dir.c
>> @@ -74,7 +74,6 @@
>>  #include "util.h"
>>
>>  #define IS_LEAF     1 /* Hashed (leaf) directory */
>> -#define IS_DINODE   2 /* Linear (stuffed dinode block) directory */
> 
> The same is true for the IS_LEAF macro. I'm adjusting the patch accordingly.
> 

I oversee this. Sorry.

> The other patch removing the LBIT macros looks good as well, so I'm
> applying both.

Thanks a lot!
Alex