From: Bart Van Assche <bart.vanassche@gmail.com>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
Greg KH <gregkh@suse.de>, Neil Brown <neilb@suse.de>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Andi Kleen <andi@firstfloor.org>, Sam Ravnborg <sam@ravnborg.org>,
Dave Jones <davej@redhat.com>,
Nikanth Karthikesan <knikanth@suse.de>,
Lars Marowsky-Bree <lmb@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Lars Ellenberg <lars.ellenberg@linbit.com>
Subject: Re: [PATCH 07/14] DRBD: internal_data_structures
Date: Sat, 11 Apr 2009 09:18:21 +0200 [thread overview]
Message-ID: <e2e108260904110018y74f39f1et39006ef9cd8f28d7@mail.gmail.com> (raw)
In-Reply-To: <1239365545-10356-8-git-send-email-philipp.reisner@linbit.com>
> +static inline void drbd_kobject_uevent(struct drbd_conf *mdev)
> +{
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,10)
> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,15)
> + kobject_uevent(disk_to_kobj(mdev->vdisk), KOBJ_CHANGE, NULL);
> +#else
> + kobject_uevent(disk_to_kobj(mdev->vdisk), KOBJ_CHANGE);
> + /* rhel4 / sles9 and older don't have this at all,
> + * which means user space (udev) won't get events about possible changes of
> + * corresponding resource + disk names after the initial drbd minor creation.
> + */
> +#endif
> +#endif
> +}
There exist scripts which accept a kernel patch and a kernel version
and remove all code that does not apply to the specified kernel
version. Maybe it's a good idea to run the DRBD code through such a
script before posting it for review.
Bart.
next prev parent reply other threads:[~2009-04-11 7:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 12:12 [PATCH 00/14] DRBD: a block device for HA clusters Philipp Reisner
2009-04-10 12:12 ` [PATCH 01/14] DRBD: major.h Philipp Reisner
2009-04-10 12:12 ` [PATCH 02/14] DRBD: lru_cache Philipp Reisner
2009-04-10 12:12 ` [PATCH 03/14] DRBD: activity_log Philipp Reisner
2009-04-10 12:12 ` [PATCH 04/14] DRBD: bitmap Philipp Reisner
2009-04-10 12:12 ` [PATCH 05/14] DRBD: request Philipp Reisner
2009-04-10 12:12 ` [PATCH 06/14] DRBD: userspace_interface Philipp Reisner
2009-04-10 12:12 ` [PATCH 07/14] DRBD: internal_data_structures Philipp Reisner
2009-04-10 12:12 ` [PATCH 08/14] DRBD: main Philipp Reisner
2009-04-10 12:12 ` [PATCH 09/14] DRBD: receiver Philipp Reisner
2009-04-10 12:12 ` [PATCH 10/14] DRBD: proc Philipp Reisner
2009-04-10 12:12 ` [PATCH 11/14] DRBD: worker Philipp Reisner
2009-04-10 12:12 ` [PATCH 12/14] DRBD: variable_length_integer_encoding Philipp Reisner
2009-04-10 12:12 ` [PATCH 13/14] DRBD: misc Philipp Reisner
2009-04-10 12:12 ` [PATCH 14/14] DRBD: final Philipp Reisner
2009-04-11 7:18 ` Bart Van Assche [this message]
2009-04-14 13:53 ` [PATCH 07/14] DRBD: internal_data_structures Philipp Reisner
2009-04-12 16:44 ` Bart Van Assche
2009-04-16 13:35 ` Philipp Reisner
2009-04-12 16:23 ` [PATCH 06/14] DRBD: userspace_interface Bart Van Assche
2009-04-17 13:24 ` Philipp Reisner
2009-04-14 2:33 ` Kyle Moffett
2009-04-22 10:31 ` Philipp Reisner
2009-04-16 7:06 ` [PATCH 05/14] DRBD: request Bart Van Assche
2009-04-16 15:32 ` Philipp Reisner
2009-04-10 12:24 ` [PATCH 02/14] DRBD: lru_cache Bart Van Assche
2009-04-14 11:54 ` Nikanth Karthikesan
2009-04-15 15:29 ` Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e108260904110018y74f39f1et39006ef9cd8f28d7@mail.gmail.com \
--to=bart.vanassche@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=knikanth@suse.de \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@suse.de \
--cc=nab@linux-iscsi.org \
--cc=neilb@suse.de \
--cc=philipp.reisner@linbit.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®