* [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
@ 2026-11-18 9:31 Michal Simek
2026-11-19 1:28 ` kernel test robot
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Michal Simek @ 2026-11-18 9:31 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Laurent Pinchart, Mauro Carvalho Chehab,
moderated list:ARM/ZYNQ ARCHITECTURE,
open list:XILINX VIDEO IP CORES
There is missing return value check from clk_prepare_enable(). Fix it by
using devm_clk_get_enabled() macro.
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
drivers/media/platform/xilinx/xilinx-vip.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/xilinx/xilinx-vip.c b/drivers/media/platform/xilinx/xilinx-vip.c
index f1574edd2b43..b8a06328b8bb 100644
--- a/drivers/media/platform/xilinx/xilinx-vip.c
+++ b/drivers/media/platform/xilinx/xilinx-vip.c
@@ -212,18 +212,16 @@ int xvip_init_resources(struct xvip_device *xvip)
if (IS_ERR(xvip->iomem))
return PTR_ERR(xvip->iomem);
- xvip->clk = devm_clk_get(xvip->dev, NULL);
+ xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
if (IS_ERR(xvip->clk))
return PTR_ERR(xvip->clk);
- clk_prepare_enable(xvip->clk);
return 0;
}
EXPORT_SYMBOL_GPL(xvip_init_resources);
void xvip_cleanup_resources(struct xvip_device *xvip)
{
- clk_disable_unprepare(xvip->clk);
}
EXPORT_SYMBOL_GPL(xvip_cleanup_resources);
---
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
2026-11-18 9:31 [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled() Michal Simek
@ 2026-11-19 1:28 ` kernel test robot
2026-11-19 3:06 ` kernel test robot
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-11-19 1:28 UTC (permalink / raw)
To: Michal Simek, linux-kernel, michal.simek, git
Cc: oe-kbuild-all, Laurent Pinchart, Mauro Carvalho Chehab,
linux-media, moderated list:ARM/ZYNQ ARCHITECTURE
Hi Michal,
kernel test robot noticed the following build errors:
[auto build test ERROR on v7.4-rc3]
[also build test ERROR on linus/master next-20261116]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Simek/media-xilinx-vip-Make-use-of-the-devm_clk_get_enabled/20261118-103132
base: v7.4-rc3
patch link: https://lore.kernel.org/r/abfe9f93f9f93d256b0d60d081e6111d7169c08f.1794994290.git.michal.simek%40amd.com
patch subject: [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
config: arm-randconfig-1000-20261119 (https://download.01.org/0day-ci/archive/20261119/202611190940.8mpjaLm0-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261119/202611190940.8mpjaLm0-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611190940.8mpjaLm0-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/media/platform/xilinx/xilinx-vip.c: In function 'xvip_init_resources':
>> drivers/media/platform/xilinx/xilinx-vip.c:215:21: error: implicit declaration of function 'devm_clk_get_enable'; did you mean 'devm_clk_get_enabled'? [-Wimplicit-function-declaration]
215 | xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
| ^~~~~~~~~~~~~~~~~~~
| devm_clk_get_enabled
>> drivers/media/platform/xilinx/xilinx-vip.c:215:19: error: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
215 | xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
| ^
vim +215 drivers/media/platform/xilinx/xilinx-vip.c
206
207 int xvip_init_resources(struct xvip_device *xvip)
208 {
209 struct platform_device *pdev = to_platform_device(xvip->dev);
210
211 xvip->iomem = devm_platform_ioremap_resource(pdev, 0);
212 if (IS_ERR(xvip->iomem))
213 return PTR_ERR(xvip->iomem);
214
> 215 xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
216 if (IS_ERR(xvip->clk))
217 return PTR_ERR(xvip->clk);
218
219 return 0;
220 }
221 EXPORT_SYMBOL_GPL(xvip_init_resources);
222
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
2026-11-18 9:31 [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled() Michal Simek
2026-11-19 1:28 ` kernel test robot
@ 2026-11-19 3:06 ` kernel test robot
2026-11-19 4:39 ` kernel test robot
2026-11-19 9:46 ` Markus Elfring
3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-11-19 3:06 UTC (permalink / raw)
To: Michal Simek, linux-kernel, michal.simek, git
Cc: llvm, oe-kbuild-all, Laurent Pinchart, Mauro Carvalho Chehab,
linux-media, moderated list:ARM/ZYNQ ARCHITECTURE
Hi Michal,
kernel test robot noticed the following build errors:
[auto build test ERROR on v7.4-rc3]
[also build test ERROR on linus/master next-20261116]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Simek/media-xilinx-vip-Make-use-of-the-devm_clk_get_enabled/20261118-103132
base: v7.4-rc3
patch link: https://lore.kernel.org/r/abfe9f93f9f93d256b0d60d081e6111d7169c08f.1794994290.git.michal.simek%40amd.com
patch subject: [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
config: loongarch-randconfig-1001-20261119 (https://download.01.org/0day-ci/archive/20261119/202611191027.Md4LUs3M-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 67ab6538dff0ed2593b90166214d93e992c74905)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261119/202611191027.Md4LUs3M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611191027.Md4LUs3M-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/media/platform/xilinx/xilinx-vip.c:215:14: error: call to undeclared function 'devm_clk_get_enable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
215 | xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
| ^
drivers/media/platform/xilinx/xilinx-vip.c:215:14: note: did you mean 'devm_clk_get_enabled'?
include/linux/clk.h:632:13: note: 'devm_clk_get_enabled' declared here
632 | struct clk *devm_clk_get_enabled(struct device *dev, const char *id);
| ^
>> drivers/media/platform/xilinx/xilinx-vip.c:215:12: error: incompatible integer to pointer conversion assigning to 'struct clk *' from 'int' [-Wint-conversion]
215 | xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
vim +/devm_clk_get_enable +215 drivers/media/platform/xilinx/xilinx-vip.c
206
207 int xvip_init_resources(struct xvip_device *xvip)
208 {
209 struct platform_device *pdev = to_platform_device(xvip->dev);
210
211 xvip->iomem = devm_platform_ioremap_resource(pdev, 0);
212 if (IS_ERR(xvip->iomem))
213 return PTR_ERR(xvip->iomem);
214
> 215 xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
216 if (IS_ERR(xvip->clk))
217 return PTR_ERR(xvip->clk);
218
219 return 0;
220 }
221 EXPORT_SYMBOL_GPL(xvip_init_resources);
222
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
2026-11-18 9:31 [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled() Michal Simek
2026-11-19 1:28 ` kernel test robot
2026-11-19 3:06 ` kernel test robot
@ 2026-11-19 4:39 ` kernel test robot
2026-11-19 9:46 ` Markus Elfring
3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-11-19 4:39 UTC (permalink / raw)
To: Michal Simek, linux-kernel, michal.simek, git
Cc: oe-kbuild-all, Laurent Pinchart, Mauro Carvalho Chehab,
linux-media, moderated list:ARM/ZYNQ ARCHITECTURE
Hi Michal,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v7.4-rc3]
[also build test WARNING on linus/master next-20261116]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Simek/media-xilinx-vip-Make-use-of-the-devm_clk_get_enabled/20261118-103132
base: v7.4-rc3
patch link: https://lore.kernel.org/r/abfe9f93f9f93d256b0d60d081e6111d7169c08f.1794994290.git.michal.simek%40amd.com
patch subject: [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20261119/202611191243.pxt5RLKL-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261119/202611191243.pxt5RLKL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611191243.pxt5RLKL-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/platform/xilinx/xilinx-vip.c: In function 'xvip_init_resources':
drivers/media/platform/xilinx/xilinx-vip.c:215:21: error: implicit declaration of function 'devm_clk_get_enable'; did you mean 'devm_clk_get_enabled'? [-Werror=implicit-function-declaration]
215 | xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
| ^~~~~~~~~~~~~~~~~~~
| devm_clk_get_enabled
>> drivers/media/platform/xilinx/xilinx-vip.c:215:19: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
215 | xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
| ^
cc1: some warnings being treated as errors
vim +215 drivers/media/platform/xilinx/xilinx-vip.c
206
207 int xvip_init_resources(struct xvip_device *xvip)
208 {
209 struct platform_device *pdev = to_platform_device(xvip->dev);
210
211 xvip->iomem = devm_platform_ioremap_resource(pdev, 0);
212 if (IS_ERR(xvip->iomem))
213 return PTR_ERR(xvip->iomem);
214
> 215 xvip->clk = devm_clk_get_enable(xvip->dev, NULL);
216 if (IS_ERR(xvip->clk))
217 return PTR_ERR(xvip->clk);
218
219 return 0;
220 }
221 EXPORT_SYMBOL_GPL(xvip_init_resources);
222
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled()
2026-11-18 9:31 [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled() Michal Simek
` (2 preceding siblings ...)
2026-11-19 4:39 ` kernel test robot
@ 2026-11-19 9:46 ` Markus Elfring
3 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2026-11-19 9:46 UTC (permalink / raw)
To: Michal Simek, linux-media, linux-arm-kernel, git, Mauro Carvalho Chehab
Cc: Michal Simek, Laurent Pinchart, LKML
> There is missing return value check from clk_prepare_enable(). Fix it by
> using devm_clk_get_enabled() macro.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.4-rc3#n145
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.4-rc3#n34
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-19 9:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 9:31 [PATCH] media: xilinx: vip: Make use of the devm_clk_get_enabled() Michal Simek
2026-11-19 1:28 ` kernel test robot
2026-11-19 3:06 ` kernel test robot
2026-11-19 4:39 ` kernel test robot
2026-11-19 9:46 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®