[PATCH 1/1] drm/sti: call drm_edid_connector_update when edit is NULL

[PATCH 1/1] drm/sti: call drm_edid_connector_update when edit is NULL

[Chu Guangqing]

call drm_edid_connector_update to reset the information when edit is NULL.
We can see the following comments in drm_edid.c
If EDID is NULL, reset the information.

Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
---
 drivers/gpu/drm/sti/sti_hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index 4e7c3d78b2b9..31a72f7f4d43 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -1008,6 +1008,7 @@ static int sti_hdmi_connector_get_modes(struct drm_connector *connector)
 	return count;
 
 fail:
+	drm_edid_connector_update(connector, NULL);
 	DRM_ERROR("Can't read HDMI EDID\n");
 	return 0;
 }
-- 
2.43.7

Re: [PATCH 1/1] drm/sti: call drm_edid_connector_update when edit is NULL

[Raphaël Gallais-Pou]

Hi,

Thanks for this patch.

Please change the commit subject to "drm/sti: hdmi: xxx".

Le 14/10/2025 à 08:54, Chu Guangqing a écrit :
> call drm_edid_connector_update to reset the information when edit is NULL.
> We can see the following comments in drm_edid.c
> If EDID is NULL, reset the information.
> 
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
> ---
>   drivers/gpu/drm/sti/sti_hdmi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index 4e7c3d78b2b9..31a72f7f4d43 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1008,6 +1008,7 @@ static int sti_hdmi_connector_get_modes(struct drm_connector *connector)
>   	return count;
>   
>   fail:
> +	drm_edid_connector_update(connector, NULL);
>   	DRM_ERROR("Can't read HDMI EDID\n");

Now that empty EDID has been properly updated, the DRM_ERROR can be 
removed IMO.  In our use case HDMI is not systematically plugged, so 
this ERROR is quite noisy when we do not expect it.

Best regards,
Raphaël>   	return 0;
>   }