mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] of: property: Add missing of_node_get() in parse_interrupt()
@ 2023-02-28 17:40 Jean-Jacques Hiblot
  2023-02-28 19:07 ` Saravana Kannan
  0 siblings, 1 reply; 6+ messages in thread
From: Jean-Jacques Hiblot @ 2023-02-28 17:40 UTC (permalink / raw)
  To: robh+dt, frowand.list, saravanak
  Cc: gregkh, devicetree, linux-kernel, Jean Jacques Hiblot

From: Jean Jacques Hiblot <jjhiblot@traphandler.com>

As all the other parsers do, parse_interrupt() must increase the refcount
of the device_node. Otherwise the refcount is decremented every time
parse_interrupt() is called on this node, leading to a potential
use-after-free.

This is a regression introduced by commit f265f06af194 ("of: property:
Fix fw_devlink handling of interrupts/interrupts-extended"). The reason is
that of_irq_parse_one() does not increase the refcount while the previously
used of_irq_find_parent() does.

Fixes: f265f06af194 ("of: property: Fix fw_devlink handling of interrupts/interrupts-extended")
Signed-off-by: Jean Jacques Hiblot <jjhiblot@traphandler.com>
---
 drivers/of/property.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 134cfc980b70b..1f23bcb765c4e 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1380,7 +1380,10 @@ static struct device_node *parse_interrupts(struct device_node *np,
 	    strcmp(prop_name, "interrupts-extended"))
 		return NULL;
 
-	return of_irq_parse_one(np, index, &sup_args) ? NULL : sup_args.np;
+	if (of_irq_parse_one(np, index, &sup_args))
+		return NULL;
+
+	return of_node_get(sup_args.np);
 }
 
 static const struct supplier_bindings of_supplier_bindings[] = {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-03-01  9:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 17:40 [PATCH] of: property: Add missing of_node_get() in parse_interrupt() Jean-Jacques Hiblot
2023-02-28 19:07 ` Saravana Kannan
2023-02-28 21:01   ` Rob Herring
2023-02-28 21:57     ` Saravana Kannan
2023-02-28 23:51       ` Rob Herring
2023-03-01  9:29   ` Jean-Jacques Hiblot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®