mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc: "Ren Zhijie" <renzhijie2@huawei.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	seanjc@google.com, "Johannes Weiner" <hannes@cmpxchg.org>,
	ojeda@kernel.org, "Masami Hiramatsu" <mhiramat@kernel.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	atomlin@redhat.com, ddiss@suse.de,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] init/Kconfig: fix unmet direct dependencies
Date: Wed, 28 Sep 2022 11:32:11 +0200	[thread overview]
Message-ID: <e33cc08b-612b-4786-9b68-262c43af5ccb@www.fastmail.com> (raw)
In-Reply-To: <YzQQfW3h70OIiT14@linutronix.de>

On Wed, Sep 28, 2022, at 11:14 AM, Sebastian Andrzej Siewior wrote:
> On 2022-09-28 09:20:42 [+0200], Lukas Bulwahn wrote:
>> > Couldn't this become a depends?
>> It could also be a depends (to resolve the warning).
> …
>> It is just the question whether:
>> 
>> When PROC_FS is not set, should the CHECKPOINT_RESTORE still be
>> visible as a config option to add (and then automatically add
>> PROC_FS)? Then select is right here.
>
> then CHECKPOINT_RESTORE is the only option selecting PROC_FS while
> everyone else depends on it _or_ avoids using it in the absence of
> PROC_FS.

Right, we should not mix 'select' and 'depends on' for the same
symbol, as that leads to circular dependencies and general
confusion.

If there is no way to use CHECKPOINT_RESTORE without procfs,
then the symbol should just not be visible (it will still show
up with the dependency when one searches in menuconfig).
Force-enabling a major subsystem like procfs from another
symbol is not a good solution.

    Arnd

  reply	other threads:[~2022-09-28  9:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28  6:49 Ren Zhijie
2022-09-28  7:01 ` Sebastian Andrzej Siewior
2022-09-28  7:20   ` Lukas Bulwahn
2022-09-28  7:52     ` Ren Zhijie
2022-09-28  9:14     ` Sebastian Andrzej Siewior
2022-09-28  9:32       ` Arnd Bergmann [this message]
2022-09-28 11:43         ` Lukas Bulwahn
2022-09-29  6:48         ` Ren Zhijie
2022-09-28  7:12 ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e33cc08b-612b-4786-9b68-262c43af5ccb@www.fastmail.com \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=ddiss@suse.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=masahiroy@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    --cc=renzhijie2@huawei.com \
    --cc=seanjc@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®