mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Bryan Brattlof <bb@ti.com>, Nishanth Menon <nm@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ARM Linux Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: k3-am62p: Add nodes for more IPs
Date: Thu, 19 Oct 2023 11:25:30 +0530	[thread overview]
Message-ID: <e35d333a-7f24-4a3f-90e3-87bc859a18e3@ti.com> (raw)
In-Reply-To: <20231018194839.2689377-2-bb@ti.com>


> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> index aaf4b793b58e7..e37f19f7e58ea 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> @@ -6,17 +6,35 @@
>  
>  &cbass_wakeup {
>  	wkup_conf: bus@43000000 {
> -		bootph-all;
>  		compatible = "simple-bus";
>  		reg = <0x00 0x43000000 0x00 0x20000>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		ranges = <0x00 0x00 0x43000000 0x20000>;
> +		bootph-all;
>  
>  		chipid: chipid@14 {
> -			bootph-all;
>  			compatible = "ti,am654-chipid";
>  			reg = <0x14 0x4>;
> +			bootph-all;
> +		};
> +
> +		cpsw_efuse: syscon@200 {
> +			compatible = "syscon", "simple-mfd";
> +			reg = <0x200 0x4>;

This holds mac-address which is at least 48bits long

> +			bootph-all;
> +		};
> +
> +		usb0_phy_pll_refclk: syscon@4008 {
> +			compatible = "syscon", "simple-mfd";
> +			reg = <0x4008 0x10>;
> +			bootph-all;
> +		};
> +
> +		usb1_phy_pll_refclk: syscon@4018 {
> +			compatible = "syscon", "simple-mfd";
> +			reg = <0x4018 0x10>;
> +			bootph-all;

This adds new dtbs_check warnings:

+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@100000: $nodename:0: 'syscon@100000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@200: compatible: ['syscon', 'simple-mfd'] is too short
+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@4008: compatible: ['syscon', 'simple-mfd'] is too short
+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@4018: compatible: ['syscon', 'simple-mfd'] is too short


I suggest to drop them for now.

Please add a new yamls for these nodes or single yaml for top level wkup_conf to 
cover am62/62a/62p SoCs and then introduce the nodes accordingly

Regards
Vignesh

  reply	other threads:[~2023-10-19  5:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 19:48 [PATCH v2 0/2] arm64: dts: ti: enable more peripherals Bryan Brattlof
2023-10-18 19:48 ` [PATCH v2 1/2] arm64: dts: ti: k3-am62p: Add nodes for more IPs Bryan Brattlof
2023-10-19  5:55   ` Vignesh Raghavendra [this message]
2023-10-19 14:26     ` Bryan Brattlof
2023-10-18 19:48 ` [PATCH v2 2/2] arm64: dts: ti: k3-am62p5-sk: Updates for SK EVM Bryan Brattlof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e35d333a-7f24-4a3f-90e3-87bc859a18e3@ti.com \
    --to=vigneshr@ti.com \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®